Pixellight #559
Pixellight #559
Conversation
| int lightyellow = 0xfff27a; | ||
|
|
||
| //others | ||
| lightColorMap["PLAYERLIGHT"] = white; |
There was a problem hiding this comment.
This should just be a struct or a series of variables, then there won't be any look-ups and you won't need a prepareLightColors function.
// light_color.h
extern const int LIGHT_FIREARROW;// light_colors.cpp
namespace {
constexpr int kBlue = 0x0000ff;
}
const int LIGHT_FIREARROW = kBlue;There was a problem hiding this comment.
but I'd need an extern for each variable :P
|
Tried to run this branch and got a bunch of issues:
What could it be? |
|
Spent most of a day looking into this. It appears that SDL_SetColorKey and SDL_ConvertSurface do not always work together. Found that the Surface tmp was not being created with transparent regions as expected. The SDL wiki here suggests that Convert surface is best used to optimize repeated blits, since we discard the converted surface every frame, we are probably safe to skip this step, and create ui_texture directly from ui_surface. (At least that is the fix that resolved this problem for me). |
| @@ -962,6 +996,53 @@ void SaveGame() | |||
| dwLen = codec_get_encoded_len(tbuff - SaveBuff); | |||
| pfile_write_save_file(szName, SaveBuff, tbuff - SaveBuff, dwLen); | |||
| mem_free_dbg(SaveBuff); | |||
| #ifdef PIXEL_LIGHT | |||
There was a problem hiding this comment.
seems this could use restoring tbuff to previous value after custom saving/loading ends, it didn't corrupt saves in this case but when moved to a different place, it would
|
Please tell me how can I add this enhancement in 1.4.1 actual version of devilutionx |
you can't |
Fully working now :)
Done:
support multiple colorsplayer lightmissilesstatic lightsfix static lights jumping arounddeal with light being cut off on lower resolutionsfix first load have no static lightsstop the light system from affecting main menu etc.make the fadein/fadeout when loading/going to/from main menu work properlycreate a global table for missile color (and radius?)add custom colors to missilesdeal with cursor having opaque rectangle around during fadesrewrite red on death/pause to work with pixel lightmake light work during lagstop quest area and normal level lights from interferingsave static lights with characterreset static light table between gamesfix unique monster light jump aroundfix light staying after unique monster teleports(vanilla bug) - kind of fixed, even if broken, will try to follow the monster : Padd light in townTo do:
color explosion of missiles properly
optimize performance