Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Elemental Arrows vs Objects #6507

Merged

Conversation

kphoenix137
Copy link
Collaborator

Fixes #5839

Fire and Lightning elemental bows will create their respective fire/lightning missiles on the object they are destroying. This also lets us remove the Fire Melee damage power from Flamedart without any change in behavior.

@AJenbo AJenbo added this to the 1.6.0 milestone Aug 31, 2023
@kphoenix137 kphoenix137 force-pushed the fix-elemental-arrows-vs-barrels branch from eed8c3a to 1e63176 Compare April 19, 2024 00:15
@kphoenix137 kphoenix137 requested a review from AJenbo April 19, 2024 00:15
AJenbo
AJenbo previously approved these changes Sep 17, 2024
@AJenbo AJenbo enabled auto-merge (rebase) September 17, 2024 22:12
@AJenbo
Copy link
Member

AJenbo commented Sep 17, 2024

This breaks some item regeneration test, please adjust there expected values in the test (if it's an expected change).

@AJenbo AJenbo dismissed their stale review September 17, 2024 22:20

Test failing

auto-merge was automatically disabled September 17, 2024 22:22

Head branch was pushed to by a user without write access

@AJenbo AJenbo merged commit d8e58b2 into diasurgical:master Sep 17, 2024
23 checks passed
@AJenbo AJenbo added the vanilla Bugs found also in the original Diablo 1.09b release label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vanilla Bugs found also in the original Diablo 1.09b release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flamedart bug
2 participants