Bump libfmt #6585
Merged
Bump libfmt #6585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully we'll be able to get rid of the custom nxdk fork soon.
AJenbo
approved these changes
Sep 11, 2023
Yeah more changes needed to remove the Xbox one, this is just the first step (see PR description) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully we'll be able to get rid of the custom nxdk fork soon.
Disabling
FMT_OSis the first step towards that. I've also asked the fmt author about handling Windows-like platforms without Unicode support in fmtlib/fmt#3631.The 3ds build was initially failing due to the 3ds SDK defining a macro (
PACKED) with the same name as an fmt template argument. Now fixed (worked around). fmtlib/fmt#3632.