Fix visually overlapping sprites for wall spells

[kphoenix137]

Fixes: #7205

Fixes the problem where wall spells create visible missiles that overlap in the center of the wall, resulting in double damage.

[qndel]

why touch all that whitespace stuff?

[kphoenix137]

why touch all that whitespace stuff?

what?

[qndel]

why touch all that whitespace stuff?

what?

all that stuff that was basically 2 duplicated blocks of code reusing variable names, you changed that to 2 sets of variables, why introduce unnecessary diff? Makes it harder to review ;)

[kphoenix137]

why touch all that whitespace stuff?

what?

all that stuff that was basically 2 duplicated blocks of code reusing variable names, you changed that to 2 sets of variables, why introduce unnecessary diff? Makes it harder to review ;)

Please provide suggested changed and I'll commit

[obligaron]

Looks good to me, expect some naming suggestions. Thanks 🙂

Personally I would like to do more refactoring. For example introduce a ProcessWallControl that is used for both FireWall and LightningWall. Also I'm thinking about having startPositionLeft and startPositionRight and removing the { } that are only there for scoping. But all this is not directly related to the bugfix. 😁

[obligaron]

thanks 🙂

[AJenbo]

A word or two on what the issue is makes the log a bit more useful :)