Rename Missile::_mirange to Missile::duration #7214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qndel
reviewed
Jul 26, 2024
kphoenix137
force-pushed
the
refactor-mirange
branch
from
ebf01bb
to
f95ecfd
Compare
obligaron
reviewed
Aug 27, 2024
`mirange` is a bit confusing. `miduration` adequately describes what the missile is used for, as the intent is the amount of ticks the missile exists for, often decremented every tick until it hits 0, when the missile is destroyed.
kphoenix137
force-pushed
the
refactor-mirange
branch
from
23ae70f
to
cf93ea5
Compare
kphoenix137
changed the title
AJenbo
approved these changes
Sep 23, 2024
AJenbo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_mirangeis a bit confusing.durationadequately describes what the missile is used for, as the intent is the amount of ticks the missile exists for, often decremented every tick until it hits 0, when the missile is destroyed.