Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read object is not fully exposed to python #645

Closed
camillescott opened this issue Oct 31, 2014 · 7 comments
Closed

Read object is not fully exposed to python #645

camillescott opened this issue Oct 31, 2014 · 7 comments

Comments

@camillescott
Copy link
Member

_khmermodule.cc defines most of the machinery for a Read type (a simple struct declared in read_parsers.hh), but does not define a __new__ method and doesn't fully expose it to python. This would be convenient for some applications.

@mr-c
Copy link
Contributor

mr-c commented Dec 17, 2014

@brtaylor92 status?

@mr-c
Copy link
Contributor

mr-c commented Feb 19, 2015

See #728 for a detailed checklist.

@ctb
Copy link
Member

ctb commented Jun 13, 2015

Fixed; see #728 and linked issues.

@ctb ctb closed this as completed Jun 13, 2015
@mr-c
Copy link
Contributor

mr-c commented Jun 13, 2015

Using ipython I'm not see how to make a new ReadParser read from Python...

@ctb
Copy link
Member

ctb commented Jun 13, 2015

Please go ahead and file a new issue, then, with more specifics about what's needed. More important IMO is #769.

@mr-c
Copy link
Contributor

mr-c commented Jun 13, 2015

We should make exposing the read object part of #769 then as that is all
the same code area.

On Sat, Jun 13, 2015 at 11:47 AM C. Titus Brown notifications@github.com
wrote:

Please go ahead and file a new issue, then, with more specifics about
what's needed. More important IMO is #769
#769.


Reply to this email directly or view it on GitHub
#645 (comment).

Michael R. Crusoe: Programmer & Bioinformatician crusoe@ucdavis.edu
mcrusoe@msu.edu
The lab for Data Intensive Biology; University of California, Davis
https://impactstory.org/MichaelRCrusoe http://twitter.com/biocrusoe

@ctb
Copy link
Member

ctb commented Jun 13, 2015

I would like to see a specific use case, so -0 on just including it to round things out. So far we have no need to create a Read object in Python that I can see, and until we no longer depend on screed we have access to screed.Record().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants