Large scale cel #495
Large scale cel #495
Conversation
…o large_scale_cel
…o large_scale_cel
There was a problem hiding this comment.
I don't think that we need have two different script that only differs by selected learner.
Perhaps, you can use argparse to select learner
There was a problem hiding this comment.
I don't think that we need have two different script that only differs by selected learner. Perhaps, you can use argparse to select learner
I merged both files into dbpedia_concept_learning_with_ontolearn.py
There was a problem hiding this comment.
I don't think that there is a need to merge a script into devl branch that doesn't work.
So, either ensure that this code is compartiable with the dev branch or remove it from your PR.
There was a problem hiding this comment.
I don't think that there is a need to merge a script into devl branch that doesn't work. So, either ensure that this code is compartiable with the dev branch or remove it from your PR.
Removed this file
There was a problem hiding this comment.
Your changes in the init decrease the quality of code by
- adding more lines than required
- multiple assertions without unique information
There was a problem hiding this comment.
Your changes in the init decrease the quality of code by
- adding more lines than required
- multiple assertions without unique information
Resolved, see below
ontolearn/binders.py
Outdated
| @@ -348,3 +351,316 @@ def fit_from_iterable(self, dataset: List = None, max_runtime=None) -> List[Dict | |||
| self.max_runtime = max_runtime | |||
|
|
|||
| return [self.fit(pos=p, neg=n, max_runtime=self.max_runtime).best_hypothesis() for (s, p, n) in dataset] | |||
|
|
|||
|
|
|||
| class DLLearnerBinderSPARQL: | |||
There was a problem hiding this comment.
We do not need to create yet another binder.
Please ensure that the content of this class in DLLearnerBinder.
There was a problem hiding this comment.
We do not need to create yet another binder. Please ensure that the content of this class in DLLearnerBinder.
Removed DLLearnerBinderSPARQL, added its content into DLLearnerBinder
README.md
Outdated
| @@ -118,6 +118,20 @@ print(owl_expression_to_sparql(expression=h)) | |||
| save_owl_class_expressions(expressions=h,path="owl_prediction") | |||
| ``` | |||
|
|
|||
| - With one command | |||
There was a problem hiding this comment.
Please remove these lines. There is no need to repeat exact same commands multiple times
There was a problem hiding this comment.
Should I remove all three commands? From line 121 onwards.
There was a problem hiding this comment.
Done. I removed the three commands
Added python scripts to run TDL and Drill on DBpedia learning problems with
"https://dbpedia.data.dice-research.org/sparql"as knowledge source.Updated README with
Bashcommands to start class expression learningAlso fixed some typos in README, e.g.,
Learining OWL Class Expressionsinstead ofLearining OWL Class ExpressionI can add the
Bashcommand for DL-Learner as well before merge, but execution freezes after some minutes. It is unable to solve even a single learning problem