Crawled data graph #130
Open
Crawled data graph #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging develop to master
…y and changes in frontier-context.xml to set env variables
… changes in SPARQL query to retreive endTimeStamps
… retreive outdated uris
…st and few changes
…rrel into sparql_recrawling
…spark dependencies
…ccording to domain
…onship between nodes
…cording to domains
… of triples in the corresponding domain
MichaelRoeder
requested changes
Jan 8, 2020
squirrel.frontier/src/main/java/org/dice_research/squirrel/components/FrontierComponent.java
Show resolved
Hide resolved
...ier/src/main/java/org/dice_research/squirrel/frontier/recrawling/FrontierQueryGenerator.java
Show resolved
Hide resolved
|
|
||
| import org.dice_research.squirrel.data.uri.CrawleableUri; | ||
|
|
||
| public interface OutDatedUriRetriever extends Closeable { |
There was a problem hiding this comment.
Please add a Javadoc that describes the functionality of this interface.
...ier/src/main/java/org/dice_research/squirrel/frontier/recrawling/FrontierQueryGenerator.java
Show resolved
Hide resolved
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| public class SparqlhostConnector implements OutDatedUriRetriever { |
There was a problem hiding this comment.
Please add a Javadoc comment describing the functionality of this class.
Please choose a better name for this class, e.g., SparqlBasedOutDatedUriRetriever
...ontier/src/main/java/org/dice_research/squirrel/frontier/recrawling/SparqlhostConnector.java
Show resolved
Hide resolved
...ontier/src/main/java/org/dice_research/squirrel/frontier/recrawling/SparqlhostConnector.java
Show resolved
Hide resolved
squirrel.frontier/src/test/java/org/dice_research/squirrel/frontier/impl/FrontierImplTest.java
Show resolved
Hide resolved
|
Hi, This branch is not updated with SPARQL recrawling changes. It's only for crawledDataGraph module. I created a different branch for recrawling feature. I don't know why it is mixed up. I'll send a different PR for recrawling. Thanks! |
|
You already have this PR: #126 |
|
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case is not correctly implemented yet. But the code is working.