Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question answering 234 #254

Merged
merged 3 commits into from
May 23, 2018
Merged

Question answering 234 #254

merged 3 commits into from
May 23, 2018

Conversation

nikit-srivastava
Copy link
Member

@nikit-srivastava nikit-srivastava commented May 22, 2018 •
edited
Loading

Implementation of LCQUAD dataset
#234

@nikit-srivastava
Copy link
Member Author

@MichaelRoeder Please Review

Also, could you please do a deployment of the same after the merge? :)

RicardoUsbeck
RicardoUsbeck previously requested changes May 23, 2018
View reviewed changes
Copy link
Collaborator

@RicardoUsbeck RicardoUsbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change qa.commons version in gerbil's pom

@nikit-srivastava
Copy link
Member Author

@RicardoUsbeck Could you please review again.

MichaelRoeder
MichaelRoeder approved these changes May 23, 2018
View reviewed changes
Copy link
Member

@MichaelRoeder MichaelRoeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelRoeder MichaelRoeder merged commit d1f52e6 into dice-group:QuestionAnswering May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelRoeder MichaelRoeder MichaelRoeder approved these changes

@RicardoUsbeck RicardoUsbeck RicardoUsbeck left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikit-srivastava @RicardoUsbeck @MichaelRoeder