Skip to content

Commit

Permalink
Merge pull request #17 from dicoding-dev/bugfix/not-detected-port
Browse files Browse the repository at this point in the history
Change dockerize way
  • Loading branch information
dimasmds authored Aug 22, 2024
2 parents 55ca735 + 3091ad0 commit 48cbc2d
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 15 deletions.
17 changes: 9 additions & 8 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
FROM node:18-slim

RUN apt-get update && apt-get install -y gosu
# System level dependencies
RUN apt-get update
RUN apt install curl -y

RUN useradd -ms /bin/bash assistest
# Prepare Work Directory
RUN mkdir -p /home/direviu/app
WORKDIR /home/direviu/app
COPY --chown=direviu:direviu . .

RUN mkdir /home/assistest/app && chown -R assistest:assistest /home/assistest/app
RUN mkdir /home/assistest/student-app && chown -R assistest:assistest /home/assistest/student-app
RUN mkdir /home/assistest/report && chown -R assistest:assistest /home/assistest/report

WORKDIR /home/assistest/app
COPY --chown=assistest:assistest . .
# Preparation Submission Folder
RUN mkdir -p /home/direviu/app/student-submission

RUN npm config set package-lock false
RUN yarn install --production=true
Expand Down
5 changes: 1 addition & 4 deletions entrypoint.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
#!/bin/bash
rm -f /home/assistest/reports/report.json || true
chown -R assistest:assistest /home/assistest/student-app
exec gosu assistest "$@"
exec "$@"
3 changes: 0 additions & 3 deletions src/interface/cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import {readdirSync} from "fs";
import ReportGenerator from "../service/report-generator/report-generator";
import * as path from "path";
import * as minimist from 'minimist';
import {sync} from "del";

class Cli {
private reportPath: string;
Expand Down Expand Up @@ -31,8 +30,6 @@ class Cli {
const submissionPath = path.resolve(this.folderPath)
const reviewResult = await main.reviewSubmission(submissionPath)
reportGenerator.generate(reviewResult, submissionPath)
// remove all files in submissionPath except report.json
sync([`${submissionPath}/**`, `!${submissionPath}/report.json`], { force: true })
}
}

Expand Down

0 comments on commit 48cbc2d

Please sign in to comment.