Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct type #657

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Correct type #657

merged 1 commit into from
Sep 10, 2023

Conversation

Jason2605
Copy link
Member

Correct type

What's Changed:

EOF is defined as -1 so when comparing against a char(!= in copyFile) it's always going to be true

Type of Change:

  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Housekeeping:

  • Tests have been updated to reflect the changes done within this PR (if applicable).
  • Documentation has been updated to reflect the changes done within this PR (if applicable).

Screenshots (If Applicable):

@Jason2605 Jason2605 added the bug fix Fixes a bug within the codebase label Sep 10, 2023
@Jason2605 Jason2605 self-assigned this Sep 10, 2023
@Jason2605 Jason2605 merged commit 5ce3cad into develop Sep 10, 2023
8 checks passed
@Jason2605 Jason2605 deleted the feature/type branch September 10, 2023 21:02
This was referenced Oct 31, 2023
Closed
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Jason2605 Jason2605

Labels
bug fix Fixes a bug within the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jason2605