Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct memory count #691

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Correct memory count #691

merged 1 commit into from
Nov 2, 2023

Conversation

Jason2605
Copy link
Member

HTTP

Resolves: #666

What's Changed:

There wasn't actually an issue with the memory, just an issue with the count if the write function was called many times (larger HTTP responses). It was adding 1 to the count for the null terminator and not excluding that from the count on subsequent requests

Type of Change:

  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Housekeeping:

  • Tests have been updated to reflect the changes done within this PR (if applicable).
  • Documentation has been updated to reflect the changes done within this PR (if applicable).

Screenshots (If Applicable):

@Jason2605 Jason2605 added the bug fix Fixes a bug within the codebase label Nov 1, 2023
@Jason2605 Jason2605 self-assigned this Nov 1, 2023
@Jason2605 Jason2605 merged commit 6d44568 into develop Nov 2, 2023
8 checks passed
@Jason2605 Jason2605 deleted the feautre/htttp branch November 2, 2023 19:00
@Jason2605 Jason2605 mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixes a bug within the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Seems to be a slight memory issue
1 participant