Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont free path after first execution #719

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Dont free path after first execution #719

merged 1 commit into from
Dec 22, 2023

Conversation

Jason2605
Copy link
Member

History

Resolves: #718

What's Changed:

The path string was being freed after the first statement had been executed, meaning further statements in the REPL was using a freed string

Type of Change:

  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Housekeeping:

  • Tests have been updated to reflect the changes done within this PR (if applicable).
  • Documentation has been updated to reflect the changes done within this PR (if applicable).

Screenshots (If Applicable):

@Jason2605 Jason2605 self-assigned this Dec 21, 2023
briandowns
briandowns approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@briandowns briandowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I was just about to push a fix since I knew it was my code and then saw this. Thank you!

@Jason2605
Copy link
Member Author

Don't worry about it mate! I should have seen it in the review as well

@Jason2605 Jason2605 merged commit 0cec9fd into develop Dec 22, 2023
8 checks passed
@Jason2605 Jason2605 deleted the feature/history branch December 22, 2023 14:48
@Jason2605 Jason2605 mentioned this pull request Sep 12, 2024
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandowns briandowns briandowns approved these changes

Assignees

@Jason2605 Jason2605

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Error using CLI
2 participants
@Jason2605 @briandowns