Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog lock-scroll #286

Closed
de1ck opened this issue Jan 19, 2019 · 0 comments
Closed

Dialog lock-scroll #286

de1ck opened this issue Jan 19, 2019 · 0 comments
Labels
feature New feature or request

Comments

@de1ck
Copy link

de1ck commented Jan 19, 2019 •
edited
Loading

Mand Mobile Version

OS Version & Browser Version

Node Version, Package Management Tool

Recurring Links

Recurring Steps

Expectant Behaviors

Dialog 出现时将 body 滚动锁定
dialog 上层是使用popup 组件实现的， popup组件有提供prevent-scroll属性
文档中没有提供preventScroll属性
看代码中有preventScroll属性透传过去，默认false, 默认未true 是不是更好

Actual Behaviors
@de1ck de1ck changed the title Dialog lock-scroll 与 Dialog lock-scroll Jan 19, 2019
supergaojian added a commit that referenced this issue Jan 21, 2019
@supergaojian
fix(Dialog): fix dialog default without preventScroll
2d61169 
fix #286
@xxyan0205 xxyan0205 added the feature New feature or request label Jan 21, 2019
@de1ck de1ck mentioned this issue Feb 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xxyan0205 @de1ck