Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(picker&date-picker): handling when rolling too fast & remove redu… #633

Merged
merged 2 commits into from
Jan 8, 2020

Conversation

xxyan0205
Copy link
Collaborator

@xxyan0205 xxyan0205 commented Jan 2, 2020

背景描述

  1. 当快速滚动多个列时,因前一列滚动还未结束,回导致当前列滚动无法正确拿到滚动位置,从而导致无法确定activeItemIndex。[bug-report] Picker && DatePicker 多个column同时快速滑动,停留值异常 #632
  2. picker-column和picker-column-list上都存在padding 0 40px,导致内容区域拥挤

主要改动

  1. 兜底处理,重新定位到起始位置
  2. 去掉picker-column-list上padding

需要注意

@codecov-io
Copy link

codecov-io commented Jan 2, 2020

Codecov Report

Merging #633 into dev will increase coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #633      +/-   ##
=========================================
+ Coverage   83.4%   83.48%   +0.07%     
=========================================
  Files         98       98              
  Lines       2772     2773       +1     
  Branches     527      528       +1     
=========================================
+ Hits        2312     2315       +3     
+ Misses       315      314       -1     
+ Partials     145      144       -1
Impacted Files Coverage Δ
components/picker/picker-column.vue 84.37% <0%> (+0.09%) ⬆️
components/date-picker/index.vue 93.9% <0%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d80368...addaf35. Read the comment docs.

@xxyan0205 xxyan0205 merged commit c7aae83 into dev Jan 8, 2020
@xxyan0205 xxyan0205 deleted the fix_datepicker_rapid branch January 8, 2020 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants