animation api #1551
Open
animation api #1551
+594
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiyuki
reviewed
Oct 31, 2024
| if (!toVal && index > 0) { | ||
| const { rules: lastRules, transform: lastTransform } = actions[index - 1] | ||
| // 非第一轮取上一轮的 | ||
| toVal = lastRules.get(key) || lastTransform.get(key) |
hiyuki
reviewed
Oct 31, 2024
| duration, | ||
| delay, | ||
| timingFunction, | ||
| transformOrigin: transformOrigin.split(/\s+/) |
hiyuki
reviewed
Oct 31, 2024
| }) | ||
| } | ||
| // 创建单个animation | ||
| function getAnimation ({ key, value }: { key: string, value: string|number }, { delay, duration, easing }: ExtendWithTimingConfig, callback: boolean | AnimationCallback = false) { |
There was a problem hiding this comment.
这个callback类型怎么能是boolean呢。。
hiyuki
reviewed
Oct 31, 2024
| toVal = lastRules.get(key) || lastTransform.get(key) | ||
| } | ||
| const animation = getAnimation({ key, value: toVal! }, { delay, duration, easing }, !isSetTransformOrigin && setTransformOrigin) | ||
| isSetTransformOrigin = true |
There was a problem hiding this comment.
改为needSetCallback吧，初始值为当前step是否存在transformOrigin，一个step设置过一次之后置为false
hiyuki
reviewed
Nov 1, 2024
| duration = DEFAULT.duration, | ||
| delay = DEFAULT.delay, | ||
| timingFunction = DEFAULT.timingFunction, | ||
| transformOrigin = DEFAULT.transformOrigin |
There was a problem hiding this comment.
这里需要确认是不是每次transformOrigin都会置为默认值， 如果每个step都有默认值的话，后面那个地方每个step必然要设置transformOrigin，就不用判断那个是否need了
hiyuki
reviewed
Nov 1, 2024
|
|
||
| _formatTransformOrigin (transformOrigin) { | ||
| const transformOriginArr = transformOrigin.split(/\s+/) | ||
| if (transformOriginArr.length === 1) { |
There was a problem hiding this comment.
split之后单位需要tranUnit，比如10px需要转为数字10
hiyuki
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.