Feat: rn event target #1753
Open
Feat: rn event target #1753
+22
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 9, 2024 19:53
hiyuki
reviewed
Dec 12, 2024
| @@ -477,7 +477,8 @@ interface LayoutConfig { | |||
| export const useLayout = ({ props, hasSelfPercent, setWidth, setHeight, onLayout, nodeRef }: LayoutConfig) => { | |||
| const layoutRef = useRef({}) | |||
| const hasLayoutRef = useRef(false) | |||
| const layoutStyle: Record<string, any> = !hasLayoutRef.current && hasSelfPercent ? HIDDEN_STYLE : {} | |||
| const isFirstRender = useRef(true) | |||
| const layoutStyle: Record<string, any> = isFirstRender.current && !hasLayoutRef.current && hasSelfPercent ? HIDDEN_STYLE : {} | |||
There was a problem hiding this comment.
const layoutStyle = useMemo(()=>{return !hasLayoutRef.current && hasSelfPercent ? HIDDEN_STYLE : {}}, [hasLayoutRef.current])应该改为上面这种，不然第二次渲染必定会show，还是可能造成闪烁
hiyuki
reviewed
Dec 12, 2024
| @@ -41,10 +41,22 @@ const getTouchEvent = ( | |||
| } | |||
| ) | |||
|
|
|||
| const pendingProps = (event as any)._targetInst?.pendingProps || {} | |||
hiyuki
reviewed
Dec 12, 2024
| @@ -477,7 +477,8 @@ interface LayoutConfig { | |||
| export const useLayout = ({ props, hasSelfPercent, setWidth, setHeight, onLayout, nodeRef }: LayoutConfig) => { | |||
| const layoutRef = useRef({}) | |||
| const hasLayoutRef = useRef(false) | |||
| const layoutStyle: Record<string, any> = !hasLayoutRef.current && hasSelfPercent ? HIDDEN_STYLE : {} | |||
| const isFirstRender = useRef(true) | |||
hiyuki
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.