Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken CI #65

Closed
wants to merge 2 commits into from
Closed

Broken CI #65

wants to merge 2 commits into from

Conversation

BOPOH
Copy link
Contributor

@BOPOH BOPOH commented Jul 27, 2024

Fixes #64

@gigorok
Copy link
Member

gigorok commented Jul 27, 2024

Hello @BOPOH.

Thank you for your contributions! It will be better to freeze the friendsofphp/php-cs-fixer library to the last working version in https://github.com/didww/didww-api-3-php-sdk/blob/master/composer.json

It will allow us to prevent our library from CI failures in case of future unexpected linter library updates

Could you freeze the version instead?

@BOPOH
Copy link
Contributor Author

BOPOH commented Jul 29, 2024

@gigorok I locked the actual version. Or should I create another pull without any changes except the change in composer.json?

@gigorok
Copy link
Member

gigorok commented Jul 29, 2024

@BOPOH Yeah, only changes in composer.json please

@gigorok gigorok closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken CI
2 participants