-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add group_id to webhook events #684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvice; add group_id key to get_cloudapi_event_redis_key
…et_id is known but group_id is not
cl0ete
approved these changes
Mar 11, 2024
…ation until the processing of the redis event is complete
… can time out by themselves. This prevents a replica from trying to read a key that was included in their scan result, which has since been deleted with lock removed
…only trace/debug and warnings/errors
ff137
force-pushed
the
feat/add-group-id-to-webhooks
branch
from
March 11, 2024 19:45
2671cdc
to
a168315
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The acapy-wallet-groups and redis-events plugins were modified to be able to append the group_id to the webhook event metadata:
This PR updates to use those latest plugin releases, and updates the storage of transformed webhook events on redis to include the group_id in the redis key. This will allow us to query webhook events by group_id (in a follow-up PR).
Other amendments with this PR: