🎨 Replace SseListeners used in app #700

ff137 · 2024-03-19T20:24:15Z

The cloudapi app logic should not need to listen for SSE events. All records can be queried from ACA-Py directly.
So, this PR replaces the few remaining cases of waiting for SSE events to instead query connection/transaction records as needed.

This removes a manual endorsement call in the issuer onboarding process, and adds an additional case to the endorser such that ATTRIB transaction types are now also automatically endorsed.

…ield name

…nstead of SseListener

github-actions · 2024-03-19T20:40:48Z

Coverage Report

File	Stmts	Miss	Cover	Missing
app
main.py	80	26	68%	73–76, 100, 102, 104, 108, 115, 141–146, 151–181
app/dependencies
acapy_clients.py	24	2	92%	36, 52
auth.py	56	19	66%	31, 37–38, 41, 52–55, 62–63, 68, 74–79, 83–86, 90–91, 96
role.py	34	1	97%	56
app/exceptions
handle_acapy_call.py	24	16	33%	40–68
app/models
issuer.py	47	2	96%	34, 43
tenants.py	75	15	80%	93, 96, 105–115, 122, 125, 144–152
verifier.py	54	8	85%	30, 38–42, 79, 87–91
app/routes
connections.py	60	39	35%	26–42, 58–70, 84–100, 116–130, 149–160
definitions.py	188	92	51%	72–129, 162–163, 230–246, 259–265, 281–290, 313–314, 331–333, 368–416, 440–441, 480–550, 558–577
issuer.py	173	38	78%	66, 97, 129–131, 164, 194–196, 204, 221, 320–330, 361–372, 405–436, 477, 490, 522
jsonld.py	62	49	21%	29–92, 103–141
messaging.py	21	9	57%	31–36, 56–63
oob.py	49	32	35%	26–65, 76–88, 112–122
sse.py	32	15	53%	37–43, 66–72, 99–107, 136–142, 173–184
verifier.py	145	32	78%	58–60, 65, 103–105, 110, 152, 160–162, 167, 201–205, 214–216, 245–247, 253, 286–288, 293, 323–325, 359–361
webhooks.py	16	4	75%	30–34, 53–57
websocket_endpoint.py	18	6	67%	17–18, 27–28, 38–41
app/routes/admin
tenants.py	150	120	20%	46–156, 165–189, 197–214, 224–234, 243–255, 265–305
app/routes/wallet
credentials.py	79	54	32%	32–41, 50–62, 71–81, 90–102, 113–125, 137–146, 155–165, 174–184
dids.py	75	22	71%	24–33, 50–51, 71–72, 84–91, 99–105
jws.py	42	27	36%	35–57, 73–96
sd_jws.py	42	27	36%	36–58, 75–98
app/services
acapy_ledger.py	69	18	74%	49–50, 76–78, 117–118, 131–150, 203–204
acapy_wallet.py	40	4	90%	61–62, 96–97
revocation_registry.py	130	10	92%	342, 350–352, 382–386, 408–414
sse.py	71	55	23%	20–24, 36–49, 62–75, 91–108, 125–142, 160–183
webhooks.py	27	18	33%	14–24, 31–39
websocket.py	44	34	23%	19–22, 29–36, 45–79
app/services/event_handling
sse_listener.py	41	8	80%	50–55, 79–84
websocket_manager.py	75	32	57%	32–38, 63–67, 86–89, 96–107, 114–124, 138
app/services/issuer
acapy_issuer_v1.py	90	13	86%	32, 59–82, 163–164
acapy_issuer_v2.py	102	21	79%	48–51, 71–105, 143, 189–190, 213
app/services/onboarding
issuer.py	38	6	84%	98–100, 117–119
tenants.py	62	48	23%	26–92, 102–132
verifier.py	36	3	92%	66, 82–86
app/services/onboarding/util
register_issuer_did.py	61	7	89%	85–87, 178–180, 195
set_endorser_metadata.py	69	37	46%	26–28, 46–48, 70–72, 103–120, 132–141, 153–164, 177–189
app/services/trust_registry
actors.py	107	9	92%	94–99, 109, 208–209, 211–216, 281–284
schemas.py	49	4	92%	56–61, 91–96
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/services/verifier
acapy_verifier_v1.py	133	68	49%	36, 59–63, 74, 96–100, 105, 113, 137–141, 146, 159–169, 174–176, 182–196, 200–219, 223–235, 239–259
acapy_verifier_v2.py	140	74	47%	40–45, 65–69, 81–86, 108–112, 117, 130–135, 149–153, 158, 171–183, 188–192, 198–212, 216–235, 239–253, 257–277
app/tests/e2e
conftest.py	22	5	77%	39–47
test_jsonld.py	64	16	75%	133–168
test_tenants.py	302	15	95%	153, 197–198, 226, 596, 630–631, 640–641, 650–651, 663–664, 673–674
test_wallet_dids.py	67	10	85%	92–107
app/tests/e2e/verifier
test_verifier.py	360	1	99%	1068
app/tests/services
test_onboarding.py	86	1	99%	263
test_revocation_registry.py	135	2	99%	73, 106
app/tests/services/issuer
test_issuer.py	161	2	99%	293–296
app/tests/services/verifier
utils.py	143	89	38%	174–188, 195–214, 226–263, 271–274, 280–291, 297–306, 311–364, 375–427, 440–466, 479–517, 531–569, 583–604, 615–631, 644–650, 664–680, 694–720
app/tests/util
credentials.py	60	1	98%	149
ecosystem_connections.py	135	27	80%	284–303, 320–340, 348–387
ledger.py	49	10	80%	34, 42, 54, 62–66, 76, 82
member_acapy_clients.py	36	6	83%	47–50, 65–66, 73–74
trust_registry.py	41	3	93%	26, 29–30
webhooks.py	25	2	92%	13, 61
app/util
acapy_issuer_utils.py	18	1	94%	22
acapy_verifier_utils.py	134	82	39%	40, 48–126, 157, 164–183, 187, 194–198, 206–210, 214–218, 225–255, 261–264
credentials.py	10	4	60%	8, 12–15
extract_validation_error.py	9	7	22%	5–11
retry_method.py	35	20	43%	9–30, 68–71, 90–97
tenants.py	25	13	48%	12–17, 32–33, 40–47
endorser
main.py	33	3	91%	59–62
endorser/services
endorsement_processor.py	138	13	91%	148–158, 191–195, 207, 219, 237–238, 247–251
endorser/services/dependency_injection
container.py	14	1	93%	54
endorser/util
endorsement.py	53	10	81%	56–57, 60–61, 64–65, 68–72, 76–80
transaction_record.py	69	13	81%	51–52, 78–82, 95, 105–106, 113–121
trust_registry.py	34	4	88%	51–52, 63–67
trustregistry
crud.py	176	152	14%	15–30, 34–46, 50–62, 66–78, 82–141, 145–161, 165–194, 200–214, 218–228, 232–252, 256–283, 287–302
db.py	29	9	69%	11–15, 19–23
list_type.py	11	4	64%	11–14, 17
main.py	41	15	63%	23–32, 54–59, 64
trustregistry/registry
registry_actors.py	82	58	29%	19–22, 27–38, 45–65, 72–82, 89–99, 106–116, 121–127
registry_schemas.py	65	40	38%	24–27, 34–51, 58–92, 97–108, 113–119
webhooks/models
conversions.py	63	6	90%	70, 83, 89, 110, 145, 163
webhooks/services
acapy_events_processor.py	160	14	91%	151–161, 209–213, 241, 269–270, 294–298, 310–314
sse_manager.py	226	36	84%	153, 155–168, 202–212, 241–242, 255–269, 324–328, 334–337, 339–342, 367–368, 411–413, 447, 458–459
webhooks_redis_serivce.py	99	14	86%	61–64, 67, 122–123, 206–207, 267, 273–274, 288–294
webhooks/services/dependency_injection
container.py	18	1	94%	61
webhooks/tests
test_sse_manager.py	161	3	98%	212–213, 219
webhooks/tests/e2e
test_sse.py	81	4	95%	121, 147–150
webhooks/web
main.py	42	3	93%	77–80
webhooks/web/routers
sse.py	168	137	18%	34–38, 61–96, 121–154, 173–238, 260–301, 324–376
webhooks.py	30	14	53%	27–36, 50–63
TOTAL	10156	2001	80%

Tests	Skipped	Failures	Errors	Time
332	2 💤	0 ❌	0 🔥	10m 28s ⏱️

…tachment` method

…rsement of ATTRIB transaction)

…ed method

app/services/onboarding/util/register_issuer_did.py

github-actions · 2024-03-20T19:38:57Z

Coverage Report

File	Stmts	Miss	Cover	Missing
app
main.py	80	26	68%	73–76, 100, 102, 104, 108, 115, 141–146, 153–180
app/dependencies
acapy_clients.py	24	2	92%	36, 52
auth.py	56	19	66%	31, 37–38, 41, 52–55, 62–63, 68, 74–79, 83–86, 90–91, 96
role.py	34	1	97%	56
app/exceptions
handle_acapy_call.py	29	7	76%	50–51, 54–60, 66–71
handle_model_with_validation.py	15	5	67%	31–37
app/models
issuer.py	48	2	96%	35, 44
jsonld.py	35	5	86%	21, 45–50
oob.py	24	1	96%	26
tenants.py	76	15	80%	75, 78, 87–99, 106, 109, 128–138
verifier.py	65	12	82%	34, 42, 50–64, 101, 109–113
app/routes
connections.py	59	38	36%	32–48, 64–76, 113–138, 159–173, 188–198
definitions.py	188	92	51%	76–137, 170–171, 238–254, 269–275, 296–305, 328–329, 346–348, 383–437, 464–465, 509–589, 597–616
issuer.py	173	38	78%	92, 128, 160–162, 191, 221–223, 231, 248, 347–357, 388–399, 432–463, 504, 517, 549
jsonld.py	60	47	22%	23–90, 101–134
messaging.py	24	11	54%	32–41, 61–71
oob.py	46	28	39%	27–68, 79–92, 116–127
sse.py	32	15	53%	37–43, 66–72, 99–107, 136–142, 173–184
verifier.py	146	32	78%	64–66, 71, 109–111, 116, 158, 166–168, 173, 207–211, 220–222, 272–274, 280, 313–315, 320, 350–352, 386–388
webhooks.py	16	4	75%	30–34, 53–57
websocket_endpoint.py	18	6	67%	17–18, 27–28, 38–41
app/routes/admin
tenants.py	151	121	20%	51–170, 179–211, 219–243, 253–263, 272–288, 298–347
app/routes/wallet
credentials.py	77	52	32%	32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
dids.py	76	22	71%	28–37, 56–57, 79–80, 92–99, 107–115
jws.py	42	27	36%	35–57, 73–96
sd_jws.py	42	27	36%	36–58, 75–98
app/services
acapy_ledger.py	61	12	80%	110–111, 124–140, 196–197
acapy_wallet.py	39	4	90%	60–61, 97–98
revocation_registry.py	130	12	91%	309–313, 341, 351–353, 383–387, 412–417
sse.py	71	55	23%	20–24, 36–49, 62–75, 91–108, 125–142, 160–183
webhooks.py	27	18	33%	14–24, 31–39
websocket.py	44	34	23%	19–22, 29–36, 45–79
app/services/event_handling
sse_listener.py	41	8	80%	50–55, 79–84
websocket_manager.py	75	32	57%	32–38, 63–67, 86–89, 96–107, 114–124, 138
app/services/issuer
acapy_issuer_v1.py	91	13	86%	36, 70–98, 201–202
acapy_issuer_v2.py	106	22	79%	54–57, 81–116, 162, 224–225, 252
app/services/onboarding
issuer.py	40	6	85%	102–104, 129–131
tenants.py	63	49	22%	30–107, 117–147
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	90	21	77%	100–102, 211–233, 256–278
set_endorser_metadata.py	69	37	46%	28–30, 50–52, 76–78, 109–128, 140–149, 161–172, 185–197
app/services/trust_registry
actors.py	107	9	92%	94–99, 109, 208–209, 211–216, 281–284
schemas.py	49	4	92%	56–61, 91–96
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/services/verifier
acapy_verifier_v1.py	129	62	52%	39, 61–62, 70, 80, 102–103, 111, 119, 144–145, 153, 166–179, 190–191, 206–228, 234–256, 260–276, 282–302
acapy_verifier_v2.py	136	67	51%	43–48, 68–69, 77, 90–95, 116–117, 125, 138–143, 160–161, 169, 182–194, 205–206, 221–242, 248–269, 273–289, 295–315
app/tests/e2e
conftest.py	22	5	77%	39–47
test_jsonld.py	59	16	73%	133–168
test_tenants.py	302	15	95%	153, 197–198, 226, 596, 630–631, 640–641, 650–651, 663–664, 673–674
test_wallet_dids.py	67	10	85%	92–107
app/tests/e2e/issuer
test_save_exchange_record.py	62	1	98%	140
app/tests/e2e/verifier
test_verifier.py	424	1	99%	1070
app/tests/services
test_revocation_registry.py	135	2	99%	73, 106
app/tests/services/issuer
test_issuer.py	161	2	99%	316–319
app/tests/services/verifier
utils.py	138	85	38%	171–185, 192–229, 237–240, 246–257, 263–272, 277–330, 341–393, 406–432, 445–483, 497–535, 549–570, 581–597, 610–616, 630–646, 660–686
app/tests/util
credentials.py	60	1	98%	149
ecosystem_connections.py	136	27	80%	291–310, 327–347, 355–394
ledger.py	49	10	80%	34, 42, 54, 62–66, 76, 82
member_acapy_clients.py	36	4	89%	47–50, 73–74
trust_registry.py	41	3	93%	26, 29–30
webhooks.py	25	2	92%	13, 61
app/util
acapy_issuer_utils.py	18	1	94%	22
acapy_verifier_utils.py	133	82	38%	41, 51–130, 163, 170–189, 193, 200–204, 212–216, 220–224, 231–264, 270–273
credentials.py	11	4	64%	11, 15–18
extract_validation_error.py	9	7	22%	5–11
retry_method.py	36	21	42%	15–36, 76–77, 91–103
tenants.py	25	13	48%	12–17, 32–33, 40–47
endorser
main.py	33	3	91%	59–62
endorser/services
endorsement_processor.py	138	13	91%	148–158, 191–195, 207, 219, 237–238, 247–251
endorser/services/dependency_injection
container.py	14	1	93%	54
endorser/util
endorsement.py	58	12	79%	57–58, 62–63, 71–72, 75–76, 79–80, 94–99
transaction_record.py	54	7	87%	52–53, 69–73, 77–81, 90
trust_registry.py	34	4	88%	51–52, 63–67
trustregistry
crud.py	176	152	14%	15–30, 34–46, 50–62, 66–78, 82–141, 145–161, 165–194, 200–214, 218–228, 232–252, 256–283, 287–302
db.py	29	9	69%	11–15, 19–23
list_type.py	11	4	64%	11–14, 17
main.py	41	15	63%	23–32, 54–59, 64
trustregistry/registry
registry_actors.py	82	58	29%	19–22, 27–38, 45–65, 72–82, 89–99, 106–116, 121–127
registry_schemas.py	65	40	38%	24–27, 34–51, 58–92, 97–108, 113–119
webhooks/models
conversions.py	63	6	90%	70, 83, 89, 110, 145, 163
webhooks/services
acapy_events_processor.py	161	14	91%	152–162, 210–214, 242, 270–271, 295–299, 311–315
sse_manager.py	226	36	84%	153, 155–168, 202–212, 241–242, 255–269, 324–328, 334–337, 339–342, 367–368, 411–413, 447, 458–459
webhooks_redis_serivce.py	99	14	86%	61–64, 67, 122–123, 208–209, 271, 277–278, 292–298
webhooks/services/dependency_injection
container.py	18	1	94%	61
webhooks/tests
test_sse_manager.py	161	3	98%	212–213, 219
webhooks/tests/e2e
test_sse.py	81	4	95%	121, 147–150
webhooks/web
main.py	42	3	93%	77–80
webhooks/web/routers
sse.py	168	137	18%	34–38, 61–96, 121–154, 173–238, 260–301, 324–376
webhooks.py	30	14	53%	27–36, 50–63
TOTAL	10347	1991	81%

Tests	Skipped	Failures	Errors	Time
338	8 💤	0 ❌	0 🔥	12m 3s ⏱️

… 204 status code change for a future release that involves a breaking change

…suer_did_transaction_endorsed`

app/routes/connections.py

app/tests/exception_handling/test_handle_model_with_validation.py

+
+
+@pytest.mark.anyio
+async def test_handle_model_with_validation_error(mock_logger):


app/tests/exception_handling/test_handle_model_with_validation.py

+    field: str
+
+    @field_validator("field")
+    def validate_regex(cls, value):


app/tests/exception_handling/test_handle_acapy_call.py

+
+
+@pytest.mark.anyio
+async def test_handle_acapy_call_with_unauthorized_exception(acapy_call, mock_logger):


app/tests/exception_handling/test_handle_acapy_call.py

sonarqubecloud · 2024-03-22T09:31:19Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

github-actions · 2024-03-22T09:49:18Z

Coverage Report

File	Stmts	Miss	Cover	Missing
app
main.py	80	26	68%	73–76, 100, 102, 104, 108, 115, 141–146, 153–180
app/dependencies
acapy_clients.py	24	2	92%	36, 52
auth.py	56	19	66%	31, 37–38, 41, 52–55, 62–63, 68, 74–79, 83–86, 90–91, 96
role.py	34	1	97%	56
app/models
issuer.py	48	2	96%	35, 44
jsonld.py	35	5	86%	21, 45–50
oob.py	24	1	96%	26
tenants.py	76	15	80%	75, 78, 87–99, 106, 109, 128–138
verifier.py	65	12	82%	34, 42, 50–64, 101, 109–113
app/routes
connections.py	60	39	35%	32–48, 64–76, 113–138, 159–173, 188–199
definitions.py	188	92	51%	76–137, 170–171, 238–254, 269–275, 296–305, 328–329, 346–348, 383–437, 464–465, 509–589, 597–616
issuer.py	173	38	78%	92, 128, 160–162, 191, 221–223, 231, 248, 347–357, 388–399, 432–463, 504, 517, 549
jsonld.py	60	47	22%	23–90, 101–134
messaging.py	24	11	54%	32–41, 61–71
oob.py	46	28	39%	27–68, 79–92, 116–127
sse.py	32	15	53%	37–43, 66–72, 99–107, 136–142, 173–184
verifier.py	146	32	78%	64–66, 71, 109–111, 116, 158, 166–168, 173, 207–211, 220–222, 272–274, 280, 313–315, 320, 350–352, 386–388
webhooks.py	16	4	75%	30–34, 53–57
websocket_endpoint.py	18	6	67%	17–18, 27–28, 38–41
app/routes/admin
tenants.py	151	121	20%	51–170, 179–211, 219–243, 253–263, 272–288, 298–347
app/routes/wallet
credentials.py	77	52	32%	32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
dids.py	76	22	71%	28–37, 56–57, 79–80, 92–99, 107–115
jws.py	42	27	36%	35–57, 73–96
sd_jws.py	42	27	36%	36–58, 75–98
app/services
acapy_ledger.py	61	12	80%	110–111, 124–140, 196–197
acapy_wallet.py	39	4	90%	60–61, 97–98
revocation_registry.py	130	12	91%	309–313, 341, 351–353, 383–387, 412–417
sse.py	71	55	23%	20–24, 36–49, 62–75, 91–108, 125–142, 160–183
webhooks.py	27	18	33%	14–24, 31–39
websocket.py	44	34	23%	19–22, 29–36, 45–79
app/services/event_handling
sse_listener.py	41	8	80%	50–55, 79–84
websocket_manager.py	75	32	57%	32–38, 63–67, 86–89, 96–107, 114–124, 138
app/services/issuer
acapy_issuer_v1.py	91	13	86%	36, 70–98, 201–202
acapy_issuer_v2.py	106	22	79%	54–57, 81–116, 162, 224–225, 252
app/services/onboarding
tenants.py	63	49	22%	30–107, 117–147
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	86	3	97%	100–102
set_endorser_metadata.py	69	37	46%	28–30, 50–52, 76–78, 109–128, 140–149, 161–172, 185–197
app/services/trust_registry
actors.py	107	9	92%	94–99, 109, 208–209, 211–216, 281–284
schemas.py	49	4	92%	56–61, 91–96
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/services/verifier
acapy_verifier_v1.py	129	62	52%	39, 61–62, 70, 80, 102–103, 111, 119, 144–145, 153, 166–179, 190–191, 206–228, 234–256, 260–276, 282–302
acapy_verifier_v2.py	136	67	51%	43–48, 68–69, 77, 90–95, 116–117, 125, 138–143, 160–161, 169, 182–194, 205–206, 221–242, 248–269, 273–289, 295–315
app/tests/e2e
conftest.py	22	5	77%	39–47
test_jsonld.py	59	16	73%	133–168
test_tenants.py	302	15	95%	153, 197–198, 226, 596, 630–631, 640–641, 650–651, 663–664, 673–674
test_wallet_dids.py	67	10	85%	92–107
app/tests/e2e/issuer
test_save_exchange_record.py	62	1	98%	140
app/tests/e2e/verifier
test_verifier.py	424	1	99%	1070
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/services
test_revocation_registry.py	135	2	99%	73, 106
app/tests/services/issuer
test_issuer.py	161	2	99%	316–319
app/tests/services/verifier
utils.py	138	85	38%	171–185, 192–229, 237–240, 246–257, 263–272, 277–330, 341–393, 406–432, 445–483, 497–535, 549–570, 581–597, 610–616, 630–646, 660–686
app/tests/util
credentials.py	60	1	98%	149
ecosystem_connections.py	136	27	80%	291–310, 327–347, 355–394
ledger.py	49	10	80%	34, 42, 54, 62–66, 76, 82
member_acapy_clients.py	36	4	89%	47–50, 73–74
trust_registry.py	41	3	93%	26, 29–30
webhooks.py	25	2	92%	13, 61
app/util
acapy_issuer_utils.py	18	1	94%	22
acapy_verifier_utils.py	133	82	38%	41, 51–130, 163, 170–189, 193, 200–204, 212–216, 220–224, 231–264, 270–273
credentials.py	11	4	64%	11, 15–18
retry_method.py	36	21	42%	15–36, 76–77, 91–103
tenants.py	25	13	48%	12–17, 32–33, 40–47
endorser
main.py	33	3	91%	59–62
endorser/services
endorsement_processor.py	138	13	91%	148–158, 191–195, 207, 219, 237–238, 247–251
endorser/services/dependency_injection
container.py	14	1	93%	54
endorser/util
endorsement.py	58	6	90%	57–58, 62–63, 94–99
transaction_record.py	54	3	94%	52–53, 90
trust_registry.py	34	4	88%	51–52, 63–67
trustregistry
crud.py	176	152	14%	15–30, 34–46, 50–62, 66–78, 82–141, 145–161, 165–194, 200–214, 218–228, 232–252, 256–283, 287–302
db.py	29	9	69%	11–15, 19–23
list_type.py	11	4	64%	11–14, 17
main.py	41	15	63%	23–32, 54–59, 64
trustregistry/registry
registry_actors.py	82	58	29%	19–22, 27–38, 45–65, 72–82, 89–99, 106–116, 121–127
registry_schemas.py	65	40	38%	24–27, 34–51, 58–92, 97–108, 113–119
webhooks/models
conversions.py	63	6	90%	70, 83, 89, 110, 145, 163
webhooks/services
acapy_events_processor.py	161	14	91%	152–162, 210–214, 242, 270–271, 295–299, 311–315
sse_manager.py	226	36	84%	153, 155–168, 202–212, 241–242, 255–269, 324–328, 334–337, 339–342, 367–368, 411–413, 447, 458–459
webhooks_redis_serivce.py	99	14	86%	61–64, 67, 122–123, 208–209, 271, 277–278, 292–298
webhooks/services/dependency_injection
container.py	18	1	94%	61
webhooks/tests
test_sse_manager.py	161	3	98%	212–213, 219
webhooks/tests/e2e
test_sse.py	81	4	95%	121, 147–150
webhooks/web
main.py	42	3	93%	77–80
webhooks/web/routers
sse.py	168	137	18%	34–38, 61–96, 121–154, 173–238, 260–301, 324–376
webhooks.py	30	14	53%	27–36, 50–63
TOTAL	10590	1940	82%

Tests	Skipped	Failures	Errors	Time
364	8 💤	0 ❌	0 🔥	11m 54s ⏱️

cl0ete

LGTM

ff137 added 2 commits March 19, 2024 22:19

✨ update coroutine_with_retry_until_value method to take optional f…

d105b3a

…ield name

✨ use coroutine_with_retry_until_value calling get_transaction, i…

c51f4d6

…nstead of SseListener

ff137 temporarily deployed to dev March 19, 2024 20:25 — with GitHub Actions Inactive

ff137 added 14 commits March 19, 2024 22:49

🎨 increase retry_delay

35cac32

🎨 raise exception if expected value not returned

92ae27b

🎨 add generic typing

41825c0

🎨 update log levels

e7de941

🎨 move valid payload check to `get_did_and_schema_id_from_cred_def_at…

b58e61f

…tachment` method

🎨 deduplicate by using operation_type and use TransactionTypes

1f923c0

🎨 deduplicate TransactionTypes

c182237

🎨 import

d0bdf80

🎨 deduplicate applicable_transaction_state

02b8784

🎨 implement wait_issuer_did_transaction_endorsed (removes manual endo…

b2dc402

…rsement of ATTRIB transaction)

🎨 implement wait_endorser_connection_completed (removes SSE listening)

22355c2

🎨 returns issuer_connection_id for wait_issuer_did_transaction_endors…

5176cdc

…ed method

Merge branch 'development' into art/remove-listeners

c7afc91

🎨 return types

36e65e7

ff137 had a problem deploying to dev March 20, 2024 15:51 — with GitHub Actions Error

🎨

148ca6e

ff137 had a problem deploying to dev March 20, 2024 15:54 — with GitHub Actions Failure

github-advanced-security bot found potential problems Mar 20, 2024

View reviewed changes

app/services/onboarding/util/register_issuer_did.py Dismissed Show dismissed Hide dismissed

app/services/onboarding/util/register_issuer_did.py Dismissed Show dismissed Hide dismissed

✅ fix test mock

6655cb8

ff137 had a problem deploying to dev March 20, 2024 17:16 — with GitHub Actions Error

✅ fix test mock

a88b61f

ff137 had a problem deploying to dev March 20, 2024 19:03 — with GitHub Actions Failure

🎨 expected that is transaction_acked, not transaction-acked

6a805c8

ff137 temporarily deployed to dev March 20, 2024 19:20 — with GitHub Actions Inactive

⏪ revert what is _technically_ a breaking change, and save the 200 ->…

c7c9ea9

… 204 status code change for a future release that involves a breaking change

ff137 added 11 commits March 22, 2024 10:09

🎨

fb5cac4

✅ test coverage for handle_acapy_call method

6c875de

✅ test coverage for handle_model_with_validation method

9cf5e37

✅ improve test coverage for onboarding issuer

cd74a93

🚚 move onboarding tests

25fae37

🎨 adjust max retries

90cfc32

🎨 parameterise max_attempts and retry_delay

586e800

✅ test coverage for wait_endorser_connection_completed and `wait_is…

efa1a04

…suer_did_transaction_endorsed`

✅ expand test coverage refactored endorsement methods

9e36c93

✅ expand test coverage

cc3c47a

🎨

bcfd369

ff137 had a problem deploying to dev March 22, 2024 09:24 — with GitHub Actions Error

github-advanced-security bot found potential problems Mar 22, 2024

View reviewed changes

🎨 fix codacy warnings

f7fb0d5

ff137 self-assigned this Mar 22, 2024

ff137 added the enhancement New feature or request label Mar 22, 2024

ff137 temporarily deployed to dev March 22, 2024 09:31 — with GitHub Actions Inactive

ff137 requested a review from cl0ete March 22, 2024 09:34

cl0ete approved these changes Mar 22, 2024

View reviewed changes

ff137 merged commit f0aa62d into development Mar 22, 2024
44 checks passed

ff137 deleted the art/remove-listeners branch March 22, 2024 10:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎨 Replace SseListeners used in app #700

🎨 Replace SseListeners used in app #700

ff137 commented Mar 19, 2024 •

edited

Loading

github-actions bot commented Mar 19, 2024

github-actions bot commented Mar 20, 2024

sonarqubecloud bot commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

cl0ete left a comment



		@pytest.mark.anyio
		async def test_handle_model_with_validation_error(mock_logger):



		@pytest.mark.anyio
		async def test_handle_acapy_call_with_unauthorized_exception(acapy_call, mock_logger):

🎨 Replace SseListeners used in app #700

🎨 Replace SseListeners used in app #700

Conversation

ff137 commented Mar 19, 2024 • edited Loading

github-actions bot commented Mar 19, 2024

github-actions bot commented Mar 20, 2024

sonarqubecloud bot commented Mar 22, 2024

Quality Gate passed

github-actions bot commented Mar 22, 2024

cl0ete left a comment

Choose a reason for hiding this comment

ff137 commented Mar 19, 2024 •

edited

Loading