🐛 Fix double endorsement

[ff137]

Resolves double endorsement issue when running with more than one endorser replica.

Fixes duplicate webhook events in general!

Primary change in our custom redis-events plugin: didx-xyz/aries-acapy-plugins#114

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[cl0ete]

I like

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
app
main.py	80	26	68%	73–76, 100, 102, 104, 108, 115, 141–146, 153–180
app/dependencies
acapy_clients.py	24	2	92%	36, 52
auth.py	56	19	66%	31, 37–38, 41, 52–55, 62–63, 68, 74–79, 83–86, 90–91, 96
role.py	34	1	97%	56
app/models
issuer.py	48	2	96%	35, 44
jsonld.py	35	5	86%	21, 45–50
oob.py	24	1	96%	26
tenants.py	76	15	80%	75, 78, 87–99, 106, 109, 128–138
verifier.py	65	12	82%	34, 42, 50–64, 101, 109–113
app/routes
connections.py	60	39	35%	32–48, 64–76, 113–138, 159–173, 188–199
definitions.py	188	92	51%	76–137, 170–171, 238–254, 269–275, 296–305, 328–329, 346–348, 383–437, 464–465, 509–589, 597–616
issuer.py	173	38	78%	92, 128, 160–162, 191, 221–223, 231, 248, 347–357, 388–399, 432–463, 504, 517, 549
jsonld.py	60	47	22%	23–90, 101–134
messaging.py	24	11	54%	32–41, 61–71
oob.py	46	28	39%	27–68, 79–92, 116–127
sse.py	32	15	53%	37–43, 66–72, 99–107, 136–142, 173–184
verifier.py	146	32	78%	64–66, 71, 109–111, 116, 158, 166–168, 173, 207–211, 220–222, 272–274, 280, 313–315, 320, 350–352, 386–388
webhooks.py	16	4	75%	30–34, 53–57
websocket_endpoint.py	18	6	67%	17–18, 27–28, 38–41
app/routes/admin
tenants.py	151	121	20%	51–170, 179–211, 219–243, 253–263, 272–288, 298–347
app/routes/wallet
credentials.py	77	52	32%	32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
dids.py	76	22	71%	28–37, 56–57, 79–80, 92–99, 107–115
jws.py	42	27	36%	35–57, 73–96
sd_jws.py	42	27	36%	36–58, 75–98
app/services
acapy_ledger.py	61	12	80%	110–111, 124–140, 196–197
acapy_wallet.py	39	4	90%	60–61, 97–98
revocation_registry.py	130	12	91%	309–313, 341, 351–353, 383–387, 412–417
sse.py	71	55	23%	20–24, 36–49, 62–75, 91–108, 125–142, 160–183
webhooks.py	27	18	33%	14–24, 31–39
websocket.py	44	34	23%	19–22, 29–36, 45–79
app/services/event_handling
sse_listener.py	41	8	80%	50–55, 79–84
websocket_manager.py	75	32	57%	32–38, 63–67, 86–89, 96–107, 114–124, 138
app/services/issuer
acapy_issuer_v1.py	91	13	86%	36, 70–98, 201–202
acapy_issuer_v2.py	106	22	79%	54–57, 81–116, 162, 224–225, 252
app/services/onboarding
tenants.py	63	49	22%	30–107, 117–147
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	86	3	97%	100–102
set_endorser_metadata.py	69	37	46%	28–30, 50–52, 76–78, 109–128, 140–149, 161–172, 185–197
app/services/trust_registry
actors.py	107	9	92%	94–99, 109, 208–209, 211–216, 281–284
schemas.py	49	4	92%	56–61, 91–96
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/services/verifier
acapy_verifier_v1.py	129	62	52%	39, 61–62, 70, 80, 102–103, 111, 119, 144–145, 153, 166–179, 190–191, 206–228, 234–256, 260–276, 282–302
acapy_verifier_v2.py	136	67	51%	43–48, 68–69, 77, 90–95, 116–117, 125, 138–143, 160–161, 169, 182–194, 205–206, 221–242, 248–269, 273–289, 295–315
app/tests/e2e
conftest.py	22	5	77%	39–47
test_jsonld.py	59	16	73%	133–168
test_tenants.py	302	15	95%	153, 197–198, 226, 596, 630–631, 640–641, 650–651, 663–664, 673–674
test_wallet_dids.py	67	10	85%	92–107
app/tests/e2e/issuer
test_save_exchange_record.py	62	1	98%	140
app/tests/e2e/verifier
test_verifier.py	424	1	99%	1070
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/services
test_revocation_registry.py	135	2	99%	73, 106
app/tests/services/issuer
test_issuer.py	161	2	99%	316–319
app/tests/services/verifier
utils.py	138	85	38%	171–185, 192–229, 237–240, 246–257, 263–272, 277–330, 341–393, 406–432, 445–483, 497–535, 549–570, 581–597, 610–616, 630–646, 660–686
app/tests/util
credentials.py	60	1	98%	149
ecosystem_connections.py	136	27	80%	291–310, 327–347, 355–394
ledger.py	49	10	80%	34, 42, 54, 62–66, 76, 82
member_acapy_clients.py	36	4	89%	47–50, 73–74
trust_registry.py	41	1	98%	26
webhooks.py	25	2	92%	13, 61
app/util
acapy_issuer_utils.py	18	1	94%	22
acapy_verifier_utils.py	133	82	38%	41, 51–130, 163, 170–189, 193, 200–204, 212–216, 220–224, 231–264, 270–273
credentials.py	11	4	64%	11, 15–18
retry_method.py	36	21	42%	15–36, 76–77, 91–103
tenants.py	25	13	48%	12–17, 32–33, 40–47
endorser
main.py	33	3	91%	59–62
endorser/services
endorsement_processor.py	137	14	90%	90, 152–162, 195–199, 211, 223, 241–242, 251–255
endorser/services/dependency_injection
container.py	14	1	93%	54
endorser/util
endorsement.py	58	6	90%	57–58, 62–63, 94–99
transaction_record.py	54	3	94%	52–53, 90
trust_registry.py	34	4	88%	51–52, 63–67
trustregistry
crud.py	176	152	14%	15–30, 34–46, 50–62, 66–78, 82–141, 145–161, 165–194, 200–214, 218–228, 232–252, 256–283, 287–302
db.py	29	9	69%	11–15, 19–23
list_type.py	11	4	64%	11–14, 17
main.py	41	15	63%	23–32, 54–59, 64
trustregistry/registry
registry_actors.py	82	58	29%	19–22, 27–38, 45–65, 72–82, 89–99, 106–116, 121–127
registry_schemas.py	65	40	38%	24–27, 34–51, 58–92, 97–108, 113–119
webhooks/models
conversions.py	63	6	90%	70, 83, 89, 110, 145, 163
webhooks/services
acapy_events_processor.py	161	15	91%	92, 155–165, 213–217, 245, 273–274, 298–302, 314–318
sse_manager.py	226	36	84%	153, 155–168, 202–212, 241–242, 255–269, 324–328, 334–337, 339–342, 367–368, 411–413, 447, 458–459
webhooks_redis_serivce.py	102	17	83%	61–64, 67, 122–123, 208–209, 271, 277–278, 292–304
webhooks/services/dependency_injection
container.py	18	1	94%	61
webhooks/tests
test_sse_manager.py	161	3	98%	212–213, 219
webhooks/tests/e2e
test_sse.py	81	4	95%	121, 147–150
webhooks/web
main.py	42	3	93%	77–80
webhooks/web/routers
sse.py	168	137	18%	34–38, 61–96, 121–154, 173–238, 260–301, 324–376
webhooks.py	30	14	53%	27–36, 50–63
TOTAL	10588	1943	82%

Tests	Skipped	Failures	Errors	Time
364	8 💤	0 ❌	0 🔥	12m 10s ⏱️