-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Validate wallet_id belongs to group_id in SSE subscriptions #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ff137
added
the
improvement
improving on something that is already existing (not a new feature as such)
label
Mar 26, 2024
ff137
commented
Mar 26, 2024
ff137
force-pushed
the
feat/sse-with-groupid
branch
from
March 26, 2024 11:02
5dbfeb2
to
a4368c3
Compare
ff137
force-pushed
the
feat/sse-with-groupid
branch
from
March 26, 2024 11:32
1db7664
to
39247a3
Compare
Quality Gate passedIssues Measures |
cl0ete
approved these changes
Mar 26, 2024
Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds assertion logic to SSE routes, so that if a group_id exists in the query parameters. we assert using redis keys that the wallet does in fact belong to that group. We raise a 403 otherwise.