-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Implement temporary endpoint to patch wallets with old group_id #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ff137
added
bug
Something isn't working
improvement
improving on something that is already existing (not a new feature as such)
labels
Apr 10, 2024
ff137
changed the title
✨ Implement route to patch wallets with old group_id
✨ Implement temporary endpoint to patch wallets with old group_id
Apr 10, 2024
cl0ete
approved these changes
Apr 10, 2024
ff137
force-pushed
the
fix/tenant-update
branch
from
April 10, 2024 13:10
fddf0b3
to
7a7201a
Compare
ff137
force-pushed
the
fix/tenant-update
branch
from
April 10, 2024 13:37
7a7201a
to
87d9566
Compare
Quality Gate passedIssues Measures |
Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
improvement
improving on something that is already existing (not a new feature as such)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PRs introduced backward incompatibility:
Summary:
group_id
used to be stored as an attribute of a wallet recordThis PR introduces a temporary PUT endpoint which will patch old wallets with the correct group_id pattern. The route has a
dry_run
query param to see what will be executed before actually running.