Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Update trust registry models #808

Merged
merged 8 commits into from
May 17, 2024
Merged

Conversation

ff137
Copy link
Collaborator

@ff137 ff137 commented May 17, 2024

Previously trust registry models were defined in two locations: one place using TypedDicts, the other pydantic BaseModels. Now we consistently use the pydantic models, and routes that say they return model types now actually do (no longer returns dicts instead)

@ff137 ff137 self-assigned this May 17, 2024
@ff137 ff137 added the refactor label May 17, 2024
@ff137 ff137 requested a review from cl0ete May 17, 2024 14:12
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@cl0ete cl0ete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ff137 ff137 merged commit 5d20132 into development May 17, 2024
42 of 44 checks passed
@ff137 ff137 deleted the update-trust-registry-models branch May 17, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants