🎨 👷‍♂️ K6 run Biome Lint and Format

[rblaine95]

• Run npm run format
• Set Biome Formatter Indent Style to spaces
• Set Biome Formatter Indent Width to 2
• Use biome check instead of format or lint
  • Allows Organize Imports to run
• Make npm run lint:fix not run the unsafe lint fixes
• Add an npm run lint:fix:unsafe to enable the unsafe flag

[cl0ete]

LGTM

[github-advanced-security]

Eslint (reported by Codacy) found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

[rblaine95]

Want to make sure npm run format doesn't cause anything to break.
If everything is successful after the format, I'll run the lint:fix (safe).
If everything is still successful after the safe lint, I'll run the unsafe lint.

[rblaine95]

Found the unsafe fix that was causing the k6 syntax error:

./libs/functions.js:75:11 lint/complexity/useOptionalChain  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ✖ Change to an optional chain.
  
    73 │       const firstItem = responseData[0];
    74 │       // Safely access wallet_id without optional chaining
  > 75 │       if (firstItem && firstItem.hasOwnProperty("wallet_id")) {
       │           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    76 │         return firstItem.wallet_id;
    77 │       }
  
  ℹ Unsafe fix: Change to an optional chain.
  
     73  73 │         const firstItem = responseData[0];
     74  74 │         // Safely access wallet_id without optional chaining
     75     │ - ······if·(firstItem·&&·firstItem.hasOwnProperty("wallet_id"))·{
         75 │ + ······if·(firstItem?.hasOwnProperty("wallet_id"))·{
     76  76 │           return firstItem.wallet_id;
     77  77 │         }

https://biomejs.dev/linter/rules/use-optional-chain/

It looks like K6 doesn't have ? operators.

[ff137]

@rblaine95 I'll take a look at why regression tests failed and post a separate fix. Just seems like connection record was not ready after webhook indicated it is ...

Note: one "critical" codacy issue: Unexpected console statement.
We can add the following to ignore it, considering it's not for production / to be executed in a browser.

/* eslint no-console: ["error", { allow: ["warn", "error"] }] */

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[ff137]

Nice! 🎨