-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🩹 Remove _backfill_events
method from webhooks service startup
#961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backfilling SSE queues with recent events is currently highly inefficient when many wallets exist. Fortunately this is a non-critical feature, and so can just be removed for now. A solution will be implemented as detailed in #899
ff137
added
the
improvement
improving on something that is already existing (not a new feature as such)
label
Aug 7, 2024
ff137
changed the title
🩹 Remove
🩹 Remove Aug 7, 2024
_backfill_events
method from startup_backfill_events
method from webhooks service startup
K8s Regression Test Coverage
|
Quality Gate passedIssues Measures |
K8s Test Coverage
|
K8s Regression Test Coverage
|
Codacy is currently down with an outage for one of their services. Merging as minor changes don't need codacy review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backfilling SSE queues with recent events is currently highly inefficient when many wallets exist. Fortunately this is a non-critical feature, and so can just be removed for now. A solution will be implemented as detailed in #899