-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✅ fix regression tests when fetching "trust registry" connections #975
Merged
ff137
merged 7 commits into
development
from
fix/regression-tests-trust-registry-connections
Aug 12, 2024
Merged
✅ fix regression tests when fetching "trust registry" connections #975
ff137
merged 7 commits into
development
from
fix/regression-tests-trust-registry-connections
Aug 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ff137
force-pushed
the
fix/regression-tests-trust-registry-connections
branch
from
August 12, 2024 14:19
966b16d
to
9eaae3b
Compare
…ixture definitions to be tested
K8s Regression Test Coverage
|
Quality Gate passedIssues Measures |
K8s Test Coverage
|
K8s Regression Test Coverage
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trust registry connections are established out-of-band, and therefore do not get the usual "alias" field that we can filter when we fetch records. So, we filter by "their_label" instead. This will only work if the regression-verifier tenant does not have many, many connections.
So this modifies logic to support the regression-verifier having up to 10'000 connections, and is therefore a temporary solution. A full solution should clean up temporary connections created in regression tests.