Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure global concurrency #976

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Configure global concurrency #976

merged 1 commit into from
Aug 12, 2024

Conversation

wdbasson
Copy link
Collaborator

Solve issue where deploy job from a concurrent workflow run takes the concurrency lock before the test job of a run was able to lock it. Which meant tests weren't being executed against the actual assets relevant to their commit.

Copy link

sonarcloud bot commented Aug 12, 2024

@ff137 ff137 self-requested a review August 12, 2024 12:55
@wdbasson wdbasson merged commit b39cd03 into development Aug 12, 2024
46 of 47 checks passed
@wdbasson wdbasson deleted the fix-cicd-concurrency branch August 12, 2024 12:55
Copy link
Collaborator

@ff137 ff137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure but the Deploy to EKS job here seems it may have cancelled my EKS / pytest run here: https://github.com/didx-xyz/aries-cloudapi-python/actions/runs/10351777014/job/28651869843?pr=975

@wdbasson
Copy link
Collaborator Author

Not sure but the Deploy to EKS job here seems it may have cancelled my EKS / pytest run here: https://github.com/didx-xyz/aries-cloudapi-python/actions/runs/10351777014/job/28651869843?pr=975

Ah, yes it would have because that job was still using the old concurrency group so the new workflow run will have interfered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants