-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧑💻 Remove patch proxy CICD logic #979
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdbasson
force-pushed
the
cicd-rework-patch-proxy
branch
from
August 13, 2024 13:47
6c84aa9
to
634a5c1
Compare
wdbasson
force-pushed
the
cicd-rework-patch-proxy
branch
from
August 13, 2024 16:45
71ddcdd
to
541de89
Compare
K8s Regression Test Coverage
|
wdbasson
force-pushed
the
cicd-rework-patch-proxy
branch
from
August 13, 2024 17:16
4a0ba0f
to
541de89
Compare
wdbasson
changed the title
Remove patch proxy CICD logic
🧑💻 Remove patch proxy CICD logic
Aug 13, 2024
rblaine95
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nitpick, but otherwise LGTM 👍
Co-authored-by: Robbie Blaine <4052340+rblaine95@users.noreply.github.com>
wdbasson
force-pushed
the
cicd-rework-patch-proxy
branch
from
August 14, 2024 13:24
a2f0b84
to
67b9adf
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patching the agents with RDS Proxy config is now handled via helm
--state-values-set rdsProxyEnabled=true
.Removes the need for the patch proxy step which saves some time and reduces overhead.
Also executing "regression" tests before "clean" tests since they take longer.