Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ ✨ Upgrade acapy 1.0.0 #990

Merged
merged 70 commits into from
Aug 21, 2024
Merged

⬆️ ✨ Upgrade acapy 1.0.0 #990

merged 70 commits into from
Aug 21, 2024

Conversation

cl0ete
Copy link
Collaborator

@cl0ete cl0ete commented Aug 19, 2024

Enrich revoked responses

  • Add get pending revocations endpoint (per registry)
  • Publish revocation endpoint now returns cred_rev_ids per rev_reg_id published
  • Revoke true will also return cred_rev_ids per rev_reg_id published
  • added and fixed tests

NB: /revoke endpoint no longer returns empty success (204), and instead gives RevokedResponse

Upgrade to Aca-Py v1.0.0

Copy link

sonarcloud bot commented Aug 20, 2024

@cl0ete cl0ete merged commit c1dee79 into development Aug 21, 2024
97 of 98 checks passed
@cl0ete cl0ete deleted the upgrade/acapy-1.0.0 branch August 21, 2024 12:44
Copy link
Collaborator

@ff137 ff137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great stuff! Just a couple important changes (avoid potential KeyError; and should we endorse a list of transaction ids now?), and some nitpicks: log levels and type hints

app/models/issuer.py Show resolved Hide resolved
cls, values: TxnOrPublishRevocationsResult
) -> Dict[str, Any]:
if isinstance(values, dict) and "txn" in values:
txn_list: List[TransactionRecord] = values.get("txn")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor note: this isn't actually a List[TransactionRecord]. It's a List[Dict[str,Any]], which has same shape as List[TransactionRecord]. Point being that the pydantic model doesn't have a .get method. So the type hint makes it seem like txn.get will error. So, for clarity we can just set the type hint to list of dict, and comment that it's list transactionrecord

app/routes/issuer.py Show resolved Hide resolved
app/routes/issuer.py Show resolved Hide resolved
app/routes/issuer.py Show resolved Hide resolved
app/services/revocation_registry.py Show resolved Hide resolved
app/services/revocation_registry.py Show resolved Hide resolved
app/services/revocation_registry.py Show resolved Hide resolved
app/services/revocation_registry.py Show resolved Hide resolved
app/services/revocation_registry.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants