Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded boilerplate all package to latest version #90

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

NorthBei
Copy link

@NorthBei NorthBei commented Jul 24, 2022

Descriptio

Upgraded boilerplate to latest version and update some api & config

Change

  1. Updgrade all package to lastest version
  2. Updated react 18 render api, electron-forge config
  3. Change main entry point in pakcage.json

Package upgrade/update

I upgrade all package from current to lastest.
image

and replace eslint-plugin-node with eslint-plugin-n for eslint-config-standard.

Testing

I already try to run these commands to ensure that could work well.

yarn start

image

yarn lint

image

yarn package

image

yarn make

image

and check things going well
image

Issue & Reference

electron-forge

Becasue electron-forge upgarde, we should add devContentSecurityPolicy into forge config, allow electron app load react logo from remote url for this boilerplate.

if you just want to add specific url into whitelist, you could do this:

...
      {
        mainConfig: ...,
        devContentSecurityPolicy: "img-src 'self' https://www.vectorlogo.zone;",
        renderer: { ... },
      },
...

Refs:

React 18

Upgrading react from v17 to v18, should update the render api

image

Refs:

styled-component

Because react and @types/react also upgrade to v18, and styled-component's type package not compatible the lastest version of @types/react, it will leads the createGlobalStyle api error in typescript like below image.

However, it's not affect the app running.

image

eslint-config-standard

Sinece eslint-config-standard v17.0.0, it require eslint-plugin-n instead of eslint-plugin-node.

image

Refs:

System Info

  • MacOS v10.15.6
  • Node.js v16.16.0
  • yarn v1.22.19

@NorthBei NorthBei changed the title Upgraded boilerplate to latest version Upgraded boilerplate all package to latest version Jul 24, 2022
@MatanYemini
Copy link

MatanYemini commented Sep 27, 2022

Why don't we merge it?

@NorthBei
Copy link
Author

If thers is anything should be modified before merege this PR, feel free to tell me, please.

@alanhe421
Copy link

nice job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants