Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: the path_changed event does not work on the GvmPolygon component #318

Closed
Tuhtarov opened this issue Apr 18, 2024 · 4 comments
Closed

Bug: the path_changed event does not work on the GvmPolygon component #318

Tuhtarov opened this issue Apr 18, 2024 · 4 comments
Assignees
@diegoazh
Labels
bug Something isn't working fix released

Comments

@Tuhtarov
Copy link

Tuhtarov commented Apr 18, 2024 •
edited
Loading

Describe the bug

The path_changed event does not work on the GvmPolygon component after changing the coordinates of any point or after adding a new point. At the same time, the polygon itself on the map changes.

To reproduce

To verify this, just repeat the code of this autotest and add console.log to the beginning of the updateEdited function:
https://github.com/diegoazh/gmap-vue/blob/master/packages/v3/cypress/runner/components/PolygonTest.vue

Expected behavior

The array of polygon coordinates in the reactive variable should change.

Screenshots

image
The polygon itself has changed, but the data in the reactive variable has not changed

Desktop

  • OS: windows 10
  • Browser chrome
  • Version 123.0.6312.123

Versions

  • Node: v20.11.1
  • NPM: 10.2.4
  • VUE: 3.4.21
  • VITE: 5.2.0

Package manager

  • NPM

Plugin version

  • 2.1.0
@Tuhtarov Tuhtarov added the bug Something isn't working label Apr 18, 2024
@Tuhtarov
Copy link
Author

Tuhtarov commented Apr 18, 2024 •
edited
Loading

I’ll also add that the geoposition of GvmMarker on the map does not change when the data in the reactive variable responsible for the geoposition of the marker in my vue component changes. Initially, the marker appears on the map at the coordinates specified in the variable, but does not change when the variable data is changed.

@diegoazh diegoazh self-assigned this Apr 22, 2024
@create-issue-branch Create Issue Branch
Copy link

Branch issue-318-Bug_the_path_changed_event_does_not_work_on_the_GvmPolygon_component created!

diegoazh added a commit that referenced this issue Apr 24, 2024
@diegoazh
fix(v3): remove undefined instances and fix watchers
000f1ef 
Solve: #318 #319
diegoazh added a commit that referenced this issue Apr 24, 2024
@diegoazh
fix(v3): remove exposed instances because they are always undefined a…
bdc2f86 
…nd cause errors with watchers and events

* test(v3): update cypress runner to use typescript

* chore(v3): add space between lines

* refactor(v3): improve function recycling code

* fix(v3): add autocomplete-key and promise deferred pattern to autocomplete component

* test(v3): add autocomplete component test

* refactor(v3): fix typo on autocomplete word

* chore(v3): remove unnecessary console log

* chore(v3): update autocomplete slot comment

* test(v3): add autocomplete and map component tests

* test(v3): add marker component test

We also improved the map and autocomplete component tests

* test(v3): add circle component test

We also improved other tests adding unmounted tests

* test(v3): add cluster icon component test

We also improve the circle shape component tests.

* test(v3): add component test for drawing-manager

We also improved mocks on other component tests

* chore(root): add launch config to debug current test with vite

* test(v3): add component test for heatmap layer

* test(v3): add component test for info-window component

* test(v3): add component test for kml-layer component

* test(v3): add component test for polygon-shape component

* test(v3): add component test for polyline-shape component

* test(v3): add component test for street-view-panorama component

* test(v3): add tests for main.ts module

* fix(v3): remove exposed instances because they are always undefined

* test(v3): fix marker e2e tests after the last changes

* fix(v3): remove undefined instances and fix watchers

Solve: #318 #319

* test(v3): add component unit tests and fix e2e tests

Solve: #320

* chore(v3): add new script to build for development

* chore(root): update lock file

* refactor(v3): move component promises into a factory function.

* chore(root): upgrade node version on gh actions and update lock file

* chore(root): update lock file to pnpm version 9

* chore(root): update package-manager property on the root package
github-actions bot pushed a commit that referenced this issue Apr 24, 2024
@semantic-release-bot
chore(v3): 2.1.1 [skip ci]
eaf9707 
## [2.1.1](gmv3_v2.1.0...gmv3_v2.1.1) (2024-04-24)

### Bug Fixes

* **v3:** remove exposed instances because they are always undefined and cause errors with watchers and events ([bdc2f86](bdc2f86)), closes [#318](#318) [#319](#319) [#320](#320)
@diegoazh
Copy link
Owner

Hello @Tuhtarov, first of all, thank you for reporting this issue. I fixed the issues in the new version that was landed a few minutes ago. Please test it and let me know if something else happens.
I'm going to close this issue considering it solved but, feel free to re-open it if you consider that necessary.

@Tuhtarov
Copy link
Author

Hi @diegoazh. It worked after adding the polygon-key attribute.
Thank you very much for the prompt work and for the cool library! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diegoazh diegoazh

Labels
bug Something isn't working fix released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@diegoazh @Tuhtarov