Top level statement support #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t and migrate to a more stateful output buffer mechanism to reduce the amount of things being passed around.
ssttgg
commented
Dec 13, 2022
| sb.AppendLine($"namespace {namespaceName}"); | ||
| sb.AppendOpenBracket(ref level); | ||
|
|
||
| if (!string.IsNullOrEmpty(namespaceName)) |
There was a problem hiding this comment.
Refactoing aside, this is the crux of the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4 - It's a slightly bigger PR than it had to be as I moved over to the
IndentedTextWriterto avoid playing pass the parcel with thelevelcounter quite so much - though officially it was to make unwinding the indention a bit easier.I found the tests for this a bit tricky to setup - sadly it required a new project (as far as I could be bothered to push it) and I didn't think it was worth adding full coverage of all the equality cases so I just settled on a very basic set of types.