Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme #68

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Update readme #68

merged 1 commit into from
Oct 6, 2023

Conversation

craigpastro
Copy link

Hello there 👋

Thanks for the nice package. I was reading through the readme and noticed a couple of things that I have tried to fix here:

  • Use JsonLogic consistently (it is how it is displayed on the JsonLogic homepage)
  • Fix indenting in code sample
  • Remove old(?) and misplaced example

- Use JsonLogic consistently (it is how it is displayed on the JsonLogic homepage).
- Fix indenting in code sample
- Remove old(?) and misplaced example
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #68 (9f0a370) into master (bbdc99d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   94.47%   94.47%           
=======================================
  Files           9        9           
  Lines         996      996           
=======================================
  Hits          941      941           
  Misses         38       38           
  Partials       17       17           

@diegoholiveira
Copy link
Owner

Thanks @craigpastro

@diegoholiveira diegoholiveira merged commit e3b00de into diegoholiveira:master Oct 6, 2023
8 checks passed
@craigpastro craigpastro deleted the update-readme branch October 6, 2023 18:40
renovate bot added a commit to open-feature/flagd that referenced this pull request Oct 16, 2023
….3.1 (#971)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[github.com/diegoholiveira/jsonlogic/v3](https://github.com/diegoholiveira/jsonlogic)
| require | patch | `v3.3.0` -> `v3.3.1` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>diegoholiveira/jsonlogic
(github.com/diegoholiveira/jsonlogic/v3)</summary>

###
[`v3.3.1`](https://github.com/diegoholiveira/jsonlogic/releases/tag/v3.3.1)

[Compare
Source](https://github.com/diegoholiveira/jsonlogic/compare/v3.3.0...v3.3.1)

#### What's Changed

- Update readme by
[@&#8203;craigpastro](https://github.com/craigpastro) in
[diegoholiveira/jsonlogic#68
- Enable Go 1.20 and 1.21 in ci by
[@&#8203;craigpastro](https://github.com/craigpastro) in
[diegoholiveira/jsonlogic#69
- Use the first value when min / max by
[@&#8203;diegoholiveira](https://github.com/diegoholiveira) in
[diegoholiveira/jsonlogic#72

#### New Contributors

- [@&#8203;craigpastro](https://github.com/craigpastro) made their
first contribution in
[diegoholiveira/jsonlogic#68

**Full Changelog**:
diegoholiveira/jsonlogic@v3.3.0...v3.3.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-feature/flagd).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants