Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade yoga-layout to latest version #2105

Merged
merged 6 commits into from
Jan 28, 2023
Merged

upgrade yoga-layout to latest version #2105

merged 6 commits into from
Jan 28, 2023

Conversation

jeetiss
Copy link
Collaborator

@jeetiss jeetiss commented Dec 10, 2022

yoga-layout built by emscripten with flex-gap and without eval

I create PRs for all maintained yoga repositories but it is stuck for a while

So I created my own fork, hope it can be replaced in future

it has a synchronous asm build and we can replace yoga-layout-prebuilt with no pain, but it is better to replace this with wasm asynchronous version that is two times faster and smaller in the future.

related to #1522 and #510

TODOs

  • yoga-layout has updated default position type Yoga.POSITION_TYPE_STATIC need to check that it is not breaking the CSS position property.
  • remove hacks with setFlexBasisAuto

@jeetiss jeetiss self-assigned this Dec 12, 2022
@jeetiss
Copy link
Collaborator Author

jeetiss commented Dec 12, 2022

@diegomura I need your approval here because this PR contains some controversial stuff)

@diegomura
Copy link
Owner

@jeetiss I'll try to test it asap. Thanks for focusing on this. When we used the main package, there were several issues on the build step of yoga. Using a pre-built version is nice as it doesn't involve building yoga on each user machine. Do you think it's possible to keep that? Also (and not important) if this is a fork to use in react-pdf wonder if it isn't better to have it @react-pdf/yoga directly

@diegomura
Copy link
Owner

@jeetiss this looks good! Can't test atm, but happy if you take the lead here 😄 This does not use your yet-another-yoga-layout-fork fork anymore right?

@jeetiss
Copy link
Collaborator Author

jeetiss commented Jan 28, 2023

This does not use your yet-another-yoga-layout-fork fork anymore right?

Yep! but it still has a build step to provide a commonjs version

@jeetiss jeetiss merged commit a14ca9e into master Jan 28, 2023
@jeetiss jeetiss deleted the upgrade-yoga-layout branch January 28, 2023 08:55
@carlobeltrame carlobeltrame mentioned this pull request Feb 26, 2023
54 tasks
@jhgeluk
Copy link

jhgeluk commented Sep 12, 2024

@jeetiss Does this PR fix the current memory leak issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants