-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade yoga-layout to latest version #2105
Conversation
@diegomura I need your approval here because this PR contains some controversial stuff) |
@jeetiss I'll try to test it asap. Thanks for focusing on this. When we used the main package, there were several issues on the build step of yoga. Using a pre-built version is nice as it doesn't involve building yoga on each user machine. Do you think it's possible to keep that? Also (and not important) if this is a fork to use in react-pdf wonder if it isn't better to have it |
@jeetiss this looks good! Can't test atm, but happy if you take the lead here 😄 This does not use your |
Yep! but it still has a build step to provide a |
@jeetiss Does this PR fix the current memory leak issue? |
yoga-layout built by
emscripten
withflex-gap
and withouteval
I create PRs for all maintained yoga repositories but it is stuck for a while
So I created my own fork, hope it can be replaced in future
it has a synchronous
asm
build and we can replaceyoga-layout-prebuilt
with no pain, but it is better to replace this withwasm
asynchronous version that is two times faster and smaller in the future.related to #1522 and #510
TODOs
Yoga.POSITION_TYPE_STATIC
need to check that it is not breaking the CSS position property.setFlexBasisAuto