Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused import from embed_migrations! #1750

Merged
merged 1 commit into from
Jun 2, 2018

Conversation

sgrif
Copy link
Member

@sgrif sgrif commented Jun 1, 2018

The changes for barrel support led to diesel_migrations exporting
everything required by this macro, leading to the warning being
generated.

Fixes #1739

The changes for barrel support led to `diesel_migrations` exporting
everything required by this macro, leading to the warning being
generated.

Fixes #1739
@sgrif sgrif requested a review from a team June 1, 2018 17:58
@killercup
Copy link
Member

Hm, this looks good at a first glance.

Thinking about it I'm not sure if this is not actually removing externally-visible imports. So while not important for diesel_migrations (because it hides the items in a mod), you might consider it a breaking change to migrations_macros. (This is very certainly not important in practice.)

@sgrif
Copy link
Member Author

sgrif commented Jun 1, 2018

This isn't pub use

@sgrif sgrif merged commit e45679f into master Jun 2, 2018
@sgrif sgrif deleted the sg-remove-unused-import-from-diesel-migrations branch June 2, 2018 14:10
@killercup
Copy link
Member

Oh but it's part of the derive macro's output and thus part of the user's code, right? But like I said, doesn't matter with the mod around it

@Eijebong
Copy link
Member

Eijebong commented Jun 2, 2018

@killercup Yeah, you can see it in the expanded code here #1739 (comment)

@0xcaff
Copy link

0xcaff commented Sep 19, 2018

When will this fix be released?

@weiznich
Copy link
Member

weiznich commented Sep 19, 2018

When will this fix be released?

See this comment for informations about the next release.

As workaround: Just add #![allow(unused_import)] to the module containing the macro call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants