Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded num-bigint and bigdecimal dependencies #2883

Merged
merged 4 commits into from
Sep 11, 2021
Merged

Upgraded num-bigint and bigdecimal dependencies #2883

merged 4 commits into from
Sep 11, 2021

Conversation

Razican
Copy link
Member

@Razican Razican commented Sep 1, 2021

This updates num-bigint to allow also for version 0.4, which has small changes and doesn't impact the build, and bigdecimal, which only updates its dependency on num-bigint.

@weiznich weiznich requested a review from a team September 1, 2021 16:59
@JohnTitor
Copy link
Member

CI complains of a trait bound failure.

@Razican
Copy link
Member Author

Razican commented Sep 11, 2021

CI complains of a trait bound failure.

It seems I forgot to update the dependency in diesel tests, should be working now.

@weiznich weiznich merged commit a51ebbd into diesel-rs:master Sep 11, 2021
@xrl
Copy link

xrl commented Sep 25, 2021

Can we get this cherry-picked to a 1.4.X release?

@weiznich
Copy link
Member

@xrl Feel free to do that, if that's no breaking change. If we do another patch release I would include something like that, but I will likely spend no time to do the backport on my own or issue an release just for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants