Allow to configure the used alias syntax #3722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is required because some database backends (oracle…) do not support the `table AS alias` syntax. They instead use a different syntax. To allow those backends to customize the `QueryFragment` impl for `Alias` we introduce another flag in `SqlDialect` that allows to customize the relevant impl.
pksunkara
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is required because some database backends (oracle…) do not support the
table AS aliassyntax. They instead use a different syntax. To allow those backends to customize theQueryFragmentimpl forAliaswe introduce another flag inSqlDialectthat allows to customize the relevant impl.