time: sql_type for DateTimeProxy without backend #3734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surban
force-pushed
the
fix-datetimeproxy
branch
from
53961f7
to
a3a4a7e
Compare
With the time feature enabled and no active database backend compilation fails because no sql_type is specified for DateTimeProxy. This is fixed by only deriving AsExpression for DateTimeProxy when a database backend is active.
surban
force-pushed
the
fix-datetimeproxy
branch
from
a3a4a7e
to
feff673
Compare
weiznich
approved these changes
Aug 7, 2023
|
Thanks 👍 |
weiznich
added
the
maybe backport
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
weiznich
added a commit
to weiznich/diesel
that referenced
this pull request
Aug 18, 2023
time: sql_type for DateTimeProxy without backend
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the time feature enabled and no active database backend compilation fails because no sql_type is specified for DateTimeProxy.
This is fixed by only deriving AsExpression for DateTimeProxy when a
database backend is active.
Fixes #3733