Update development setup and instructions #3777
Conversation
rust-toolchain
Outdated
| @@ -1 +1 @@ | |||
| 1.68.0 | |||
| 1.70.0 | |||
There was a problem hiding this comment.
I can understand why you made this change but that's technically not the correct MSRV. Diesel defines that as the rust version which can be used to build diesel with some set of dependency versions with. That's not necessarily the newest version of each dependency. We test this with the -Z minimal-version flag on CI and that test cannot really fail just because someone released a new version of a dependency.
Now I can understand that the current setup might be problematic for new contributors, so I'm open for that change. We should change the commit message for that.
Additionally it seems like there are some other CI issues due to new deprecated methods in chrono. Mind adding a commit addressing them as well?
CONTRIBUTING.md
Outdated
| @@ -65,7 +65,7 @@ Thank you! We'll try to respond as quickly as possible. | |||
|
|
|||
| *Shortcut:* On macOS, you don't need to install anything to work with SQLite. | |||
| For PostgreSQL, you'll only need the server (`libpq` is installed by | |||
| default). To get started, `brew install postgresql mysql` and follow the | |||
| default). To get started, `brew install postgresql@14 mysql` and follow the | |||
There was a problem hiding this comment.
Maybe we should indicate that newer versions work there as well?
The forumula are now versioned, e.g., `postgresql@14`. Previously it was just `postgresql`. fix: bump rust toolchain to 1.72.1 as this is the latest stable now
weiznich
force-pushed
the
fix-dev-setup
branch
from
a76842c to
1e610ec
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Addresses these issues:
rustversion is now1.70.0because ofanstreamandclap_completepostgresqlhas been replaced by versioned ones, e.g.,postgresql@14