Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Option field check in diesel_derives #3988

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Fix Option field check in diesel_derives #3988

merged 1 commit into from
Apr 15, 2024

Conversation

stormshield-kg
Copy link
Contributor

Fixes #3987.

@weiznich weiznich requested a review from a team April 11, 2024 13:44
@weiznich
Copy link
Member

Thanks for opening this PR. Would it be possible to add your reproduction case as test case to the diesel_derive tests?

weiznich
weiznich approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@weiznich weiznich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@weiznich weiznich added this pull request to the merge queue Apr 15, 2024
Merged via the queue into diesel-rs:master with commit 0cf6c48 Apr 15, 2024
48 checks passed
@stormshield-kg stormshield-kg deleted the fix-derive-option-ty branch April 15, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiznich weiznich weiznich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option field check in diesel_derives in incomplete
2 participants
@stormshield-kg @weiznich