Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement array_cat and array_length functions #4202

Merged
merged 7 commits into from
Aug 27, 2024
Merged

Implement array_cat and array_length functions #4202

merged 7 commits into from
Aug 27, 2024

Conversation

wowinter13
Copy link
Member

@wowinter13 wowinter13 commented Aug 25, 2024 •
edited
Loading

implemented array_cat and array_length functions for postgres under #4153

@wowinter13 wowinter13 changed the title [WIP] Implement array_cat and array_length functions Implement array_cat and array_length functions Aug 25, 2024
@wowinter13
Copy link
Member Author

@weiznich There is one failing test (@ CI Tests / Check (stable, postgres, ubuntu-latest) (pull_request) )
SIGSEGV [ 0.183s] diesel r2d2::tests::check_pool_does_actually_hold_connections
Not sure if this one is related

@guissalustiano guissalustiano requested a review from a team August 25, 2024 22:00
guissalustiano
guissalustiano suggested changes Aug 25, 2024
View reviewed changes
Copy link
Contributor

@guissalustiano guissalustiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for open the PR!

The code is good, there is just a wrong return type

diesel/src/pg/expression/functions.rs Outdated Show resolved Hide resolved
@guissalustiano
Copy link
Contributor

@weiznich There is one failing test (@ CI Tests / Check (stable, postgres, ubuntu-latest) (pull_request) )
SIGSEGV [ 0.183s] diesel r2d2::tests::check_pool_does_actually_hold_connections
Not sure if this one is related

Don't worry, it's not related with your change

@weiznich weiznich mentioned this pull request Aug 26, 2024
Open
guissalustiano
guissalustiano approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@guissalustiano guissalustiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@weiznich weiznich added this pull request to the merge queue Aug 27, 2024
Merged via the queue into diesel-rs:master with commit b718c47 Aug 27, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guissalustiano guissalustiano guissalustiano approved these changes

@weiznich weiznich weiznich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wowinter13 @guissalustiano @weiznich