Add postgres macaddr8 type support #4313
Conversation
There was a problem hiding this comment.
Thanks for submitting this PR. Overall this looks ok to me, but there are a few minor things that currently make the tests fail to compile. These need to be fixed. You also need to run the test locally at least once to update a view snapshots. You can do this via cargo xtask run-tests postgres.
You should also run cargo fmt locally before submitting the PR.
Finally it would be great to have a changelog entry for this.
| @@ -99,6 +99,7 @@ fn pg_diesel_types() -> HashSet<&'static str> { | |||
| types.insert("Inet"); | |||
| types.insert("Jsonb"); | |||
| types.insert("MacAddr"); | |||
| types.insert("MacAddr8"); | |||
There was a problem hiding this comment.
We are missing another insert below line 130 for the lowercase variant.
| /// .values(macaddr.eq([0x08, 0x00, 0x2b, 0x01, 0x02, 0x03, 0x04, 0x05])) | ||
| /// .returning(macaddr) | ||
| /// .get_result::<[u8; 8]>(connection)?; | ||
| /// assert_eq!([0x08, 0x00, 0x2b, 0x01, 0x02, 0x03, 0x04, 0x0], inserted_macaddr); |
There was a problem hiding this comment.
| /// assert_eq!([0x08, 0x00, 0x2b, 0x01, 0x02, 0x03, 0x04, 0x0], inserted_macaddr); | |
| /// assert_eq!([0x08, 0x00, 0x2b, 0x01, 0x02, 0x03, 0x04, 0x05], inserted_macaddr); |
| let expected_value = [0x08, 0x00, 0x2b, 0x01, 0x02, 0x03, 0x04, 0x05]; | ||
| assert_eq!( | ||
| expected_value, | ||
| query_single_value::<MacAddr, [u8; 8]>(query) |
There was a problem hiding this comment.
| query_single_value::<MacAddr, [u8; 8]>(query) | |
| query_single_value::<MacAddr8, [u8; 8]>(query) |
| fn pg_macaddress8_to_sql_macaddress() { | ||
| let expected_value = "'08:00:2b:01:02:03:04:05'::macaddr8"; | ||
| let value = [0x08, 0x00, 0x2b, 0x01, 0x02, 0x03, 0x04, 0x05]; | ||
| assert!(query_to_sql_equality::<MacAddr, [u8; 8]>( |
There was a problem hiding this comment.
| assert!(query_to_sql_equality::<MacAddr, [u8; 8]>( | |
| assert!(query_to_sql_equality::<MacAddr8, [u8; 8]>( |
| macaddr8_roundtrips, | ||
| MacAddr8, | ||
| (u8, u8, u8, u8, u8, u8, u8, u8), | ||
| mk_macaddr |
There was a problem hiding this comment.
This mk_macaddr is a function below in this file. We need to have a mk_macaddr8 variant there as well.
No description provided.