Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.eq_any(ARRAY(subselect)) and .eq_any(ARRAY[..., ...]) support #4353

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

.eq_any(ARRAY(subselect)) and .eq_any(ARRAY[..., ...]) support #4353

wants to merge 28 commits into from

Commits on Nov 20, 2024

  1. wip

    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    b71e8e2 View commit details
    Browse the repository at this point in the history

  2. wip

    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    91e18ee View commit details
    Browse the repository at this point in the history

  3. fix test

    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    351caa6 View commit details
    Browse the repository at this point in the history

  4. fix conflicting impl

    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    e11986e View commit details
    Browse the repository at this point in the history

  5. Attempt using AsExpression directly

    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    1fe73f5 View commit details
    Browse the repository at this point in the history

  6. Revert "Attempt using AsExpression directly" 

    This reverts commit 1fe73f5.
    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    2e1f4dc View commit details
    Browse the repository at this point in the history

  7. Improve doc of the ~deprecated AsArrayExpression

    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    801da3a View commit details
    Browse the repository at this point in the history

  8. improve doc

    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    7e6eddf View commit details
    Browse the repository at this point in the history

  9. Add helper type 

    auto_type will work only if ST is explicitly specified when calling array, which looks reasonable
    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    92eaf0d View commit details
    Browse the repository at this point in the history

  10. move helper type to same path

    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    07c6f34 View commit details
    Browse the repository at this point in the history

  11. Make it backwards-compatible for people who checked the AsExpressionL… 

    …ist bound
    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    e28a826 View commit details
    Browse the repository at this point in the history

  12. Improve doc & export trait

    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    2294ea2 View commit details
    Browse the repository at this point in the history

  13. Add impl of IntoArrayExpression for types that have `AsExpression<A… 

    …rray<...>>`
    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    7731f83 View commit details
    Browse the repository at this point in the history

  14. Update trybuild 

    Unfortunately this keeps talking about AsExpressionList instead of IntoArrayExpression :(
Hopefully Rust ends up fixing this
    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    a8f5cd5 View commit details
    Browse the repository at this point in the history

  15. Improve error message

    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    079f403 View commit details
    Browse the repository at this point in the history

  16. improve test

    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    4877b59 View commit details
    Browse the repository at this point in the history

  17. add doc

    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    488d3b0 View commit details
    Browse the repository at this point in the history

  18. improve comment

    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    6929b86 View commit details
    Browse the repository at this point in the history

  19. Allow using explicit array constructs in EqAny 

    This removes the fake Expression implementation for `Many`, instead relying on an `InExpression` trait (which replaces `MaybeEmpty`) that represents that that query fragment is valid for use inside `IN` or `= ANY`
    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    97d5627 View commit details
    Browse the repository at this point in the history

  20. Add more comment on the Subselect type

    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    7781df8 View commit details
    Browse the repository at this point in the history

  21. WIP support .eq_any(array_of_nullable_expressions)

    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    7a5c5a8 View commit details
    Browse the repository at this point in the history

  22. Add failing test that we can't select eq_any of a Nullable expression… 

    … into a bool.
    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    e656d16 View commit details
    Browse the repository at this point in the history

  23. fix nullability of IN / NOT IN / = ANY / != ALL 

    Conflicts:
	diesel/src/expression/array_comparison.rs
    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    80e8833 View commit details
    Browse the repository at this point in the history

  24. Merge branch 'fix_eq_any_nullability' into array_subselect

    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    6e4d7b7 View commit details
    Browse the repository at this point in the history

  25. generate the compile test output

    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    4d30c16 View commit details
    Browse the repository at this point in the history

  26. Merge branch 'fix_eq_any_nullability' into array_subselect

    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    a27e05c View commit details
    Browse the repository at this point in the history

  27. Showcase that it now works with nullable arrays

    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    18c44a5 View commit details
    Browse the repository at this point in the history

  28. minor doc improvement

    @Ten0
    Ten0 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    f9d768f View commit details
    Browse the repository at this point in the history