Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eclipse 4.13 support #480

Closed
k-brooks opened this issue Oct 31, 2019 · 7 comments
Closed

Eclipse 4.13 support #480

k-brooks opened this issue Oct 31, 2019 · 7 comments

Comments

@k-brooks
Copy link

Support for 4.13, please!
I'd be happy to contribute - I think I see what needs to be done based on (components of, not the default update) #423

@nedtwigg
Copy link
Member

PRs are always welcome! Here's another example, a little simpler: https://github.com/diffplug/spotless/pull/384/files

@k-brooks
Copy link
Author

As always - a speedy response @nedtwigg
Would you / diffplug prefer separate issues/PRs for the supporting _ext updates?

@k-brooks
Copy link
Author

Actually, it looks like the version ranges in the _ext artifacts will permit what is necessary, disregard.

@k-brooks
Copy link
Author

I take that back, the fat jar is bundling the pinned version.

@nedtwigg
Copy link
Member

Bumping JDT shouldn't require any changes in _ext, #384 is a canonical example.

@k-brooks
Copy link
Author

I was hoping to hit Groovy as well, we use it for Gradle and would like to have consistent eclipse versions, and figured I'd do the rest while I was there.
But can break that out if desired

@nedtwigg
Copy link
Member

Ahh, roger. Combined or broken-out is fine, either way!

nedtwigg added a commit that referenced this issue Nov 1, 2019
nedtwigg added a commit that referenced this issue Nov 1, 2019
nedtwigg added a commit that referenced this issue Nov 1, 2019
@k-brooks k-brooks closed this as completed Nov 7, 2019
@fvgh fvgh mentioned this issue Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants