Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed system line separator change from eclipse-base config #1058

Closed
wants to merge 1 commit into from

Conversation

fvgh
Copy link
Member

@fvgh fvgh commented Dec 31, 2021

  • changeSystemLineSeparator no longer part of default configuration
  • Added annotations due to spotbugs version bump

As agreed for #1049, the line separator config will no longer be part of the default configuration.
First tests shows that the System line separator is currently only used by WTP.
Tests for the different formatters will be provided in dedicated PR.

@fvgh fvgh requested a review from nedtwigg December 31, 2021 12:05
@fvgh
Copy link
Member Author

fvgh commented Dec 31, 2021

@nedtwigg As clarified in #1054, the tests are not executed for eclipse-base by CI. I made some changes to the tests due to the spotbugs version upgrade. What is the best way to enable the tests in CI, and to executed them on a bug/feature branch?

- changeSystemLineSeparator no longer part of default configuration
- Added annotations due to spotbugs version bump
@fvgh fvgh force-pushed the no-system-change-per-default branch from 7bad837 to 95533dd Compare December 31, 2021 12:23
@nedtwigg nedtwigg changed the base branch from main-temp to main April 20, 2022 21:30
@nedtwigg
Copy link
Member

@nedtwigg nedtwigg closed this Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants