Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open com.sun.tools.javac modules on JDK 16+ #1224

Merged
merged 10 commits into from
Jun 5, 2022
5 changes: 4 additions & 1 deletion lib/src/main/java/com/diffplug/spotless/Jvm.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2016-2021 DiffPlug
* Copyright 2016-2022 DiffPlug
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -48,6 +48,9 @@ public final class Jvm {
if (VERSION <= 8) {
throw new IllegalArgumentException("Expected " + jre + " to start with an integer greater than 8");
}
if (VERSION >= 16) {
ModuleHelper.doOpenInternalPackagesIfRequired();
tisonkun marked this conversation as resolved.
Show resolved Hide resolved
}
}
}

Expand Down
133 changes: 133 additions & 0 deletions lib/src/main/java/com/diffplug/spotless/ModuleHelper.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,133 @@
/*
* Copyright 2016-2022 DiffPlug
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.diffplug.spotless;

import java.lang.invoke.MethodHandle;
import java.lang.invoke.MethodHandles;
import java.lang.reflect.Field;
import java.lang.reflect.Method;
import java.lang.reflect.Modifier;
import java.util.ArrayList;
import java.util.Collection;
import java.util.HashMap;
import java.util.List;
import java.util.Map;

import javax.annotation.Nullable;

import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import sun.misc.Unsafe;

public final class ModuleHelper {
tisonkun marked this conversation as resolved.
Show resolved Hide resolved
private static final Map<String, String> REQUIRED_PACKAGES_TO_TEST_CLASSES = new HashMap<>();

static {
REQUIRED_PACKAGES_TO_TEST_CLASSES.putIfAbsent("com.sun.tools.javac.util", "Context");
REQUIRED_PACKAGES_TO_TEST_CLASSES.putIfAbsent("com.sun.tools.javac.file", "CacheFSInfo");
REQUIRED_PACKAGES_TO_TEST_CLASSES.putIfAbsent("com.sun.tools.javac.tree", "TreeTranslator");
REQUIRED_PACKAGES_TO_TEST_CLASSES.putIfAbsent("com.sun.tools.javac.parser", "Tokens$TokenKind");
REQUIRED_PACKAGES_TO_TEST_CLASSES.putIfAbsent("com.sun.tools.javac.api", "DiagnosticFormatter$PositionKind");
}

private static boolean checkDone = false;

public static synchronized void doOpenInternalPackagesIfRequired() {
if (checkDone) {
return;
}
try {
checkDone = true;
final List<String> unavailableRequiredPackages = unavailableRequiredPackages();
if (!unavailableRequiredPackages.isEmpty()) {
openPackages(unavailableRequiredPackages);
final List<String> failedToOpen = unavailableRequiredPackages();
if (!failedToOpen.isEmpty()) {
final StringBuilder message = new StringBuilder();
message.append("WARNING: Some required internal classes are unavailable. Please consider adding the following JVM arguments\n");
message.append("WARNING: ");
for (String name : failedToOpen) {
message.append(String.format("--add-opens jdk.compiler/%s=ALL-UNNAMED", name));
}
System.err.println(message);
}
}
} catch (Throwable e) {
System.err.println("WARNING: Failed to check for unavailable JDK packages. Reason: " + e.getMessage());
}
}

@SuppressFBWarnings("REC_CATCH_EXCEPTION") // workaround JDK11
private static List<String> unavailableRequiredPackages() {
final List<String> packages = new ArrayList<>();
for (Map.Entry<String, String> e : REQUIRED_PACKAGES_TO_TEST_CLASSES.entrySet()) {
final String key = e.getKey();
final String value = e.getValue();
try {
final Class<?> clazz = Class.forName(key + "." + value);
if (clazz.isEnum()) {
clazz.getMethod("values").invoke(null);
} else {
clazz.getDeclaredConstructor().newInstance();
}
} catch (IllegalAccessException ex) {
packages.add(key);
} catch (Exception ignore) {
// in old versions of JDK some classes could be unavailable
}
}
return packages;
}

@SuppressWarnings("unchecked")
private static void openPackages(Collection<String> packagesToOpen) throws Throwable {
final Collection<?> modules = allModules();
if (modules == null) {
return;
}
final Unsafe unsafe = Unsafe.getUnsafe();
final Field implLookupField = MethodHandles.Lookup.class.getDeclaredField("IMPL_LOOKUP");
final MethodHandles.Lookup lookup = (MethodHandles.Lookup) unsafe.getObject(
unsafe.staticFieldBase(implLookupField),
unsafe.staticFieldOffset(implLookupField));
final MethodHandle modifiers = lookup.findSetter(Method.class, "modifiers", Integer.TYPE);
final Method exportMethod = Class.forName("java.lang.Module").getDeclaredMethod("implAddOpens", String.class);
modifiers.invokeExact(exportMethod, Modifier.PUBLIC);
for (Object module : modules) {
final Collection<String> packages = (Collection<String>) module.getClass().getMethod("getPackages").invoke(module);
for (String name : packages) {
if (packagesToOpen.contains(name)) {
exportMethod.invoke(module, name);
}
}
}
}

@Nullable
@SuppressFBWarnings("REC_CATCH_EXCEPTION") // workaround JDK11
private static Collection<?> allModules() {
// calling ModuleLayer.boot().modules() by reflection
try {
final Object boot = Class.forName("java.lang.ModuleLayer").getMethod("boot").invoke(null);
if (boot == null) {
return null;
}
final Object modules = boot.getClass().getMethod("modules").invoke(boot);
return (Collection<?>) modules;
} catch (Exception ignore) {
return null;
}
}
}