Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated diktat version to 1.2.1 #1251

Merged
merged 5 commits into from
Jun 30, 2022
Merged

Updated diktat version to 1.2.1 #1251

merged 5 commits into from
Jun 30, 2022

Conversation

orchestr7
Copy link
Contributor

@orchestr7 orchestr7 commented Jun 30, 2022

What’s done:

  • Updated diktat version to a stable 1.2.1 release with minor bug fixes (after a non-stable 1.2.0)

@orchestr7
Copy link
Contributor Author

This PR contains critical bugfixes that we introduced in our dirty 1.2.0 release :)

@nedtwigg
Copy link
Member

I assume you want to bump this too?

private static final String DEFAULT_VERSION = "1.2.0";

Don't worry about changelog for this PR, I will handle that as I am preparing to cut a release.

@orchestr7
Copy link
Contributor Author

orchestr7 commented Jun 30, 2022

DEFAULT_VERSION

oh really, sorry for that, why do we have several versions? @Cheshiriks @nulls why not to unify them?
we have MIN_SUPPORTED_VERSION, DEFAULT_VERSION, VER_DIKTAT and hardcodes in tests!

UPD: Ah, I see - you are not able to share common version from gradle.build and MIN version will be different in the future with the DEFAULT one

@nedtwigg nedtwigg enabled auto-merge June 30, 2022 20:39
@nulls
Copy link
Contributor

nulls commented Jun 30, 2022

DEFAULT_VERSION

oh really, sorry for that, why do we have several versions? @Cheshiriks @nulls why not to unify them?
we have MIN_SUPPORTED_VERSION, DEFAULT_VERSION, VER_DIKTAT and hardcodes in tests!

UPD: Ah, I see - you are not able to share common version from gradle.build and MIN version will be different in the future with the DEFAULT one

MIN_SUPPORTED_VERSION was introduced because of changes in ktlint library which diktat calls it directly.
It's not required to upgrade min version, but still useful

@nedtwigg nedtwigg merged commit b36a16e into diffplug:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants