Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.1 - autoclosed #1300

Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 26, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.github.ekryd.sortpom:sortpom-sorter 3.0.0 -> 3.2.1 age adoption passing confidence

⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/com.github.ekryd.sortpom-sortpom-sorter-3.x branch 10 times, most recently from 4c982ab to 690212e Compare September 14, 2022 05:24
@nedtwigg
Copy link
Member

Our SortPomStep hardcodes to version 3.0.0.

this.jarState = JarState.from("com.github.ekryd.sortpom:sortpom-sorter:3.0.0", provisioner);

The underlying artifact (changelog) has a breaking change in 3.1.0, including dropping support for Java 8. If anyone wants to update this, there are two approaches:

  1. update sortPomCompileOnly as done in this PR along with L45 noted above to the whatever the latest version is
  2. use @davidburstrom's io.github.davidburstrom.version-compatibility plugin to maintain support for multiple versions of sortpom (Reinstate support for KtLint down to 0.31.0 and up to 0.47.1 (inclusive) #1303)

I would be happy to merge either approach. If it was me writing the PR, I would take option 1, it doesn't seem worth it to keep supporting old versions forever.

@renovate renovate bot force-pushed the renovate/com.github.ekryd.sortpom-sortpom-sorter-3.x branch 2 times, most recently from 05fe38e to 81cf66b Compare September 14, 2022 11:09
@renovate renovate bot changed the title Update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.0 fix(deps): update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.0 Sep 27, 2022
@renovate renovate bot changed the title fix(deps): update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.0 Update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.0 Dec 17, 2022
@renovate renovate bot changed the title Update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.0 fix(deps): update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.0 Dec 17, 2022
@renovate renovate bot force-pushed the renovate/com.github.ekryd.sortpom-sortpom-sorter-3.x branch from 81cf66b to 5f1be96 Compare January 2, 2023 05:22
@renovate renovate bot changed the title fix(deps): update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.0 Update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.0 Jan 8, 2023
@renovate renovate bot changed the title Update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.0 fix(deps): update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.0 Jan 10, 2023
@renovate renovate bot changed the title fix(deps): update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.0 Update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.0 Jan 12, 2023
@renovate renovate bot changed the title Update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.0 fix(deps): update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.0 Jan 13, 2023
@renovate renovate bot changed the title fix(deps): update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.0 Update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.0 Jan 14, 2023
@renovate renovate bot changed the title Update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.0 fix(deps): update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.0 Jan 15, 2023
@renovate renovate bot force-pushed the renovate/com.github.ekryd.sortpom-sortpom-sorter-3.x branch from 5f1be96 to 3aabfd9 Compare January 17, 2023 18:41
@renovate renovate bot changed the title fix(deps): update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.0 Update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.0 Jan 19, 2023
@renovate renovate bot changed the title Update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.0 fix(deps): update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.0 Jan 22, 2023
@renovate renovate bot changed the title fix(deps): update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.0 Update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.0 Jan 24, 2023
@diffplug diffplug deleted a comment from davidburstrom Jan 26, 2023
@diffplug diffplug deleted a comment from davidburstrom Jan 26, 2023
@diffplug diffplug deleted a comment from davidburstrom Jan 26, 2023
@diffplug diffplug deleted a comment from davidburstrom Jan 26, 2023
@diffplug diffplug deleted a comment from davidburstrom Jan 26, 2023
@nedtwigg
Copy link
Member

I deleted a discussion above related to Java 8 vs 11 complexity which is now resolved since we have updated to Java 11 in #1530. So if anybody wants this version update but was blocked by that, you should be unblocked now.

@renovate renovate bot force-pushed the renovate/com.github.ekryd.sortpom-sortpom-sorter-3.x branch from 3aabfd9 to 9697b33 Compare January 29, 2023 16:50
@renovate renovate bot changed the title Update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.0 Update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.1 Jan 29, 2023
@renovate renovate bot force-pushed the renovate/com.github.ekryd.sortpom-sortpom-sorter-3.x branch from 9697b33 to 4a2519c Compare February 11, 2023 09:10
@renovate renovate bot changed the title Update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.1 fix(deps): update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.1 Feb 28, 2023
@renovate renovate bot force-pushed the renovate/com.github.ekryd.sortpom-sortpom-sorter-3.x branch from 4a2519c to 2310ec0 Compare March 8, 2023 12:33
@renovate renovate bot force-pushed the renovate/com.github.ekryd.sortpom-sortpom-sorter-3.x branch from 2310ec0 to 6659322 Compare April 3, 2023 11:43
@renovate renovate bot force-pushed the renovate/com.github.ekryd.sortpom-sortpom-sorter-3.x branch from 6659322 to 26c04c4 Compare April 6, 2023 03:40
@renovate renovate bot changed the title fix(deps): update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.1 fix(deps): update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.1 - autoclosed Apr 20, 2023
@renovate renovate bot closed this Apr 20, 2023
@renovate renovate bot deleted the renovate/com.github.ekryd.sortpom-sortpom-sorter-3.x branch April 20, 2023 03:26
@renovate renovate bot changed the title fix(deps): update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.1 - autoclosed fix(deps): update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.1 Apr 20, 2023
@renovate renovate bot reopened this Apr 20, 2023
@renovate renovate bot restored the renovate/com.github.ekryd.sortpom-sortpom-sorter-3.x branch April 20, 2023 07:31
@renovate renovate bot changed the title fix(deps): update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.1 fix(deps): update dependency com.github.ekryd.sortpom:sortpom-sorter to v3.2.1 - autoclosed May 16, 2023
@renovate renovate bot closed this May 16, 2023
@renovate renovate bot deleted the renovate/com.github.ekryd.sortpom-sortpom-sorter-3.x branch May 16, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant