Add Android example to gradle plugin readme. #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedtwigg
reviewed
Nov 27, 2017
plugin-gradle/README.md
Outdated
| @@ -134,6 +134,19 @@ spotless { | |||
| } | |||
| ``` | |||
|
|
|||
| ## Applying to Android Java source | |||
| Be sure to add `target "**/*.java` otherwise spotless will not detect Java code inside Android modules. | |||
|
|
|||
There was a problem hiding this comment.
- Missing a trailing
" - Everywhere else in the readme we use
'instead of" - Let's make this a
### For Android Javaafter## Applying to Java source, right before## Applying to Java source (google-java-format)
Thanks for the PR, this is a good idea
|
The same thing I think is true for Kotlin as well. Due to how flavors work. Maybe add a note about that as well? |
runningcode
force-pushed
the
no/readme-android
branch
from
ef228d4
to
9570238
Compare
runningcode
force-pushed
the
no/readme-android
branch
from
9570238
to
a530a72
Compare
|
@nedtwigg Lines fixed! |
|
Thanks @runningcode! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #111